Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[546593]: Immediately refresh the marquee feedback on creation #64

Merged
merged 1 commit into from May 17, 2019
Merged

[546593]: Immediately refresh the marquee feedback on creation #64

merged 1 commit into from May 17, 2019

Conversation

CamilleLetavernier
Copy link
Contributor

  • After creating the MarqueeSelectionFeedback, immediately refresh it to make sure it is located under the mouse, so scrollbars won't have to be displayed if they're not necessary

@CamilleLetavernier
[546593]: Immediately refresh the marquee feedback on creation
1f76c6d 
- After creating the MarqueeSelectionFeedback, immediately refresh it to
make sure it is located under the mouse, so scrollbars won't have to be
displayed if they're not necessary

Signed-off-by: Camille Letavernier <cletavernier@eclipsesource.com>
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=546593
@mwienand mwienand merged commit 526feaf into eclipse:master May 17, 2019
@mwienand
Copy link
Contributor

Thank you very much for the contribution!

I will add an XXX comment to the new line, explaining that it prevents the scrollbars.

Maybe the issue is also present with other feedback and handles, so we might have to find another place for an initial refresh, in order to resolve all such issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CamilleLetavernier @mwienand