[454629] Record label attribute validation support for DotEditor #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented validation methods for the recordLabel in DotJavaValidator.java - Introduced ConvertingValidationMessageAcceptor to accept Issues in the scope of the subgrammar and register them in the scope of the Dot grammar. - Handling calculating offset in ConvertingValidationMessageAcceptor - Implemented further validation test cases: - Tests for other semantic issue (no node returned case) and Syntax issues added. Signed-off-by: Zoey Gerrit Prigge <zoey.prigge@uni-duesseldorf.de> Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=454629
|
Issue tracker reference: |
prggz
deleted the
454629_RecordLabel_Validation_DotJavaValidator_And_Tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DotJavaValidator.java
scope of the subgrammar and register them in the scope of the Dot
grammar.
issues added.
Signed-off-by: Zoey Gerrit Prigge zoey.prigge@uni-duesseldorf.de
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=454629