[WIP] [NONE] Update Contributor Guide #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nico Prediger <mail@nicoprediger.de>
NicoPrediger
force-pushed
the
npr_update_contributor_guide
branch
from
85c04d0
to
06a755e
Compare
NicoPrediger
changed the title
|
Planning on adding info about runtime configuration later... |
miklossy
approved these changes
Jan 31, 2020
laeubi
reviewed
Mar 19, 2020
| GEF uses a Maven/Tycho-based build infrastructure. With the [Eclipse Maven Integration](http://eclipse.org/m2e/), a headless build can also be executed in the local workspace. Make sure you have checked out all projects of the respective git repository. Then easily run the build by right-clicking the `pom.xml` file located within the `org.eclipse.gef.releng` project, and selecting 'Run As -> Maven build...'. | ||
|
|
||
| In the configuration wizard you have to specify the goals ("clean verify") and the target profile (e.g. "NEON.target") for the build. Note that without setting the target profile the build will not run successfully. The build needs to be executed with a Java 8 VM, so if you have installed multiple JVMs, you should check the settings in the *JRE* tab. | ||
| In the configuration wizard you have to specify the goals ("clean verify") and the target profile (e.g. "2019-03.target") for the build. Note that without setting the target profile the build will not run successfully. The build needs to be executed with a Java 11 VM, so if you have installed multiple JVMs, you should check the settings in the *JRE* tab. |
There was a problem hiding this comment.
It seems one has also to define 'JAVAFX_HOME' env variable.
Also the build complains about missing 'javadoc' variable
There was a problem hiding this comment.
@laeubi: Thanks for the hints and for the feedback!
|
Correct. We had to add this when adopting Java 11 and as it seems, we forgot to update the contributor guide. Thanks for pointing that out.
Best Regards,
Alexander
… Am 19.03.2020 um 08:48 schrieb Christoph Läubrich ***@***.***>:
'JAVAFX_HOME' env variable.
|
|
@Hejado @nyssen : What is the state of this PR? Is it ready to be merged? |
|
@Hejado wanted to cross-check when setting things up on his machine. From my point of view, nothing is open here. |
|
@nyssen Thanks for clarifying it, I will merge this PR right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[NONE] Update Contributor Guide
Signed-off-by: Nico Prediger mail@nicoprediger.de