Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of deprecated Observable classes #1

Closed
pcdavid opened this issue Jan 22, 2022 · 1 comment
Closed

Remove usage of deprecated Observable classes #1

pcdavid opened this issue Jan 22, 2022 · 1 comment
Labels
maintenance Keeping up to date with changes in the ecosystem
Milestone

Comments

@pcdavid
Copy link
Contributor

pcdavid commented Jan 22, 2022

Starting in 2019, the Eclipse Platform has marked several databinding classes as deprecated for removal. See #546820 and the migration guide.

This includes:

  • org.eclipse.jface.databinding.viewers.ViewersObservables
  • org.eclipse.jface.databinding.swt.SWTObservables
  • org.eclipse.core.databinding.beans.BeansObservables
  • org.eclipse.core.databinding.beans.PojoObservables
  • org.eclipse.ui.databinding.WorkbenchObservables

They will be completely removed in 2022-09.

GMF Runtime uses some of these, so must be adapted.

From a quick read of the comments on bug #546820, it seems that the replacements have only been complete starting from around 2020-06 (not sure yet). Depending on how GMF Runtime uses these classes, if we want to be compatible with 2022-09 where these will no longer be available, it might mean we need to drop support for platforms older than ~2020-06 (so that we can use the alternatives).

@pcdavid pcdavid added the maintenance Keeping up to date with changes in the ecosystem label Jan 22, 2022
@pcdavid
Copy link
Contributor Author

pcdavid commented May 1, 2022

As part of #6, support for platforms older than 2020-09 have been removed.
It seems that platforms supported in the upcoming version 1.15.0 now include complete replacements for the deprecated APIs, so if this is confirmed (and if time permits) this could be included in 1.15.0.

@pcdavid pcdavid added this to the 1.15.0 milestone May 1, 2022
pcdavid added a commit that referenced this issue May 4, 2022
Bug: #1
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue May 7, 2022
Bug: #1
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue May 7, 2022
Bug: #1
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid closed this as completed May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Keeping up to date with changes in the ecosystem
Projects
None yet
Development

No branches or pull requests

1 participant