Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1230] Remove assertion token. #1232

Merged
merged 1 commit into from May 20, 2019

Conversation

Projects
3 participants
@sophokles73
Copy link
Member

commented May 13, 2019

The assert Device Registration of the Device Registration API no longer
includes an assertion token in its response message. The base classes
for implementing a Device Registration service therefore no longer
creates a JWT for inclusion in the message.

@sophokles73 sophokles73 added this to the 1.0.0 milestone May 13, 2019

@sophokles73 sophokles73 requested a review from dejanb May 13, 2019

@sophokles73 sophokles73 requested a review from ctron as a code owner May 13, 2019

@sophokles73 sophokles73 added this to In progress in 1.0-M4 via automation May 13, 2019

@codecov

This comment has been minimized.

Copy link

commented May 13, 2019

Codecov Report

Merging #1232 into master will decrease coverage by 0.08%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1232      +/-   ##
============================================
- Coverage     68.52%   68.43%   -0.09%     
  Complexity      390      390              
============================================
  Files           283      282       -1     
  Lines         12851    12812      -39     
  Branches       1099     1098       -1     
============================================
- Hits           8806     8768      -38     
+ Misses         3249     3242       -7     
- Partials        796      802       +6
Impacted Files Coverage Δ Complexity Δ
...eclipse/hono/deviceregistry/ApplicationConfig.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...egistry/FileBasedRegistrationConfigProperties.java 75% <ø> (+5%) 4 <0> (ø) ⬇️
...ipse/hono/service/AbstractProtocolAdapterBase.java 79.29% <ø> (ø) 0 <0> (ø) ⬇️
...a/org/eclipse/hono/util/RegistrationConstants.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...o/deviceregistry/FileBasedRegistrationService.java 74.05% <0%> (-0.41%) 41 <0> (ø)
.../service/registration/BaseRegistrationService.java 84.09% <80%> (+0.03%) 0 <0> (ø) ⬇️
...src/main/java/org/eclipse/hono/util/JwtHelper.java 70.88% <0%> (-5.07%) 0% <0%> (ø)
...no/config/SignatureSupportingConfigProperties.java 70% <0%> (-5%) 0% <0%> (ø)
...n/java/org/eclipse/hono/config/AbstractConfig.java 58.26% <0%> (-1.74%) 0% <0%> (ø)
...a/org/eclipse/hono/client/impl/AbstractSender.java 64.74% <0%> (-1.44%) 0% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fadae90...de78ce8. Read the comment docs.

@sophokles73 sophokles73 force-pushed the bsinno:remove_assertion_token branch 2 times, most recently from bff7258 to 07b2d0e May 13, 2019

@dejanb
Copy link
Contributor

left a comment

There are a couple more places in the docs where token has been mentioned, like

https://www.eclipse.org/hono/architecture/auth/auth/
https://www.eclipse.org/hono/api/authentication-api/

for example. We should try to update that as well

@ctron

ctron approved these changes May 20, 2019

[#1230] Remove assertion token.
The assert Device Registration of the Device Registration API no longer
includes an assertion token in its response message. The base classes
for implementing a Device Registration service therefore no longer
creates a JWT for inclusion in the message.

Signed-off-by: Kai Hudalla <kai.hudalla@bosch-si.com>
@sophokles73

This comment has been minimized.

Copy link
Member Author

commented May 20, 2019

@dejanb the places you are referring to are not about the token used to assert a device's registration status but are about the token issued for a Hono component when it connects to another component.
There was, however, one other place in the docs where I removed a reference to the assertion token.

@sophokles73 sophokles73 force-pushed the bsinno:remove_assertion_token branch from 07b2d0e to de78ce8 May 20, 2019

@sophokles73 sophokles73 merged commit de1e045 into eclipse:master May 20, 2019

2 of 4 checks passed

codecov/patch 66.66% of diff hit (target 68.52%)
Details
codecov/project 68.43% (-0.09%) compared to fadae90
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details

1.0-M4 automation moved this from In progress to Done May 20, 2019

@sophokles73 sophokles73 deleted the bsinno:remove_assertion_token branch May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.