Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crossings not working properly in DatasetUtils #188

Merged
merged 1 commit into from Jun 8, 2017

Conversation

@yannick-mayeur
Copy link
Contributor

commented May 11, 2017

crossings(Dataset xAxis, Dataset yAxis, double yValue, double xRangeProportion)
not working properly.
If there are exactly 3 crossings that could have been merged it is not done
because it was using "<" instead of "<=".
w6-1

Signed-off-by: Yannick Mayeur yannick.mayeur@gmail.com

@jonahgraham

This comment has been minimized.

Copy link
Contributor

commented May 25, 2017

@yannick-mayeur when you get a chance can you update to master and add Peter as a reviewer.

Fix crossings not working properly in DatasetUtils
crossings(Dataset xAxis, Dataset yAxis, double yValue, double xRangeProportion)
not working properly.
If there are exactly 3 crossings that could have been merged it is not done
because it was using "<" instead of "<=".

Signed-off-by: Yannick Mayeur <yannick.mayeur@gmail.com>

@jonahgraham jonahgraham requested a review from PeterC-DLS May 25, 2017

@PeterC-DLS
Copy link
Contributor

left a comment

Looks fine. Thanks for the fix!

@PeterC-DLS PeterC-DLS merged commit b87a377 into eclipse:master Jun 8, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details

@yannick-mayeur yannick-mayeur deleted the yannick-mayeur:fix-crossings branch Jun 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.