Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2-hpack not visible in OSGi #1290

Closed
janbartel opened this issue Jan 27, 2017 · 8 comments
Closed

http2-hpack not visible in OSGi #1290

janbartel opened this issue Jan 27, 2017 · 8 comments

Comments

@janbartel
Copy link
Contributor

Reported on stackoverflow: http://stackoverflow.com/questions/41870597/jetty-9-http-2-in-osgi-container-cannot-load-a-httpfieldpreencoder-implementati

janbartel added a commit that referenced this issue Jan 27, 2017
@janbartel
Copy link
Contributor Author

Fixed in jetty-9.4.x master ready for 9.4.2 release.

@akurtakov
Copy link
Contributor

This causes issues for Eclipse Platform. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=512807 . Can we workaround it on our side somehow to not distribute apache aries bundles too?

@joakime
Copy link
Contributor

joakime commented Feb 28, 2017

Out of curiosity, how does the Eclipse Help system operate with HTTP/2?
HTTP/2 support requires a JVM specific Xbootclasspath setup to function.

Perhaps the Eclipse Help system should not rely on HTTP/2?
Just exclude the HTTP/2 components from your environment (they are optional anyway)

@joakime
Copy link
Contributor

joakime commented Feb 28, 2017

@akurtakov Jetty 9.4.2.v20170220 has been released.

@mbooth101
Copy link
Contributor

Eclipse does not use http2, we use the "jetty-http" bundle only.

@joakime
Copy link
Contributor

joakime commented Mar 1, 2017

@mbooth101 then exclude all of the http2 jars/bundles/components, they are not needed/used, and are optional for Jetty.

@mbooth101
Copy link
Contributor

@joakime As discussed in the Eclipse bug quoted by akurtakov above ( https://bugs.eclipse.org/bugs/show_bug.cgi?id=512807 ) the problem is that this change added the following non-optional dep to the jetty-http bundle:

Require-Capability: osgi.extender;filter:="osgi.extender=osgi.serviceloader.processor)"

It's not a case of excluding http2 bundles, it's a case of this new requirement causing bundle resolution failures because a new non-optional dependency was added to jetty-http. Since Eclipse can use jetty fine without Apache Aries bundles, we believe this dependency should be made optional.

Let me submit a PR to illustrate what change I would like to see made.

@mbooth101
Copy link
Contributor

Please see PR #1365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants