Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all jetty modules that use ServiceLoader have correct OSGi manifest headers #2164

Closed
janbartel opened this issue Jan 30, 2018 · 6 comments
Closed

Ensure all jetty modules that use ServiceLoader have correct OSGi manifest headers #2164

janbartel opened this issue Jan 30, 2018 · 6 comments
Assignees
@janbartel
Labels
Bug For general bugs on Jetty side
Milestone
9.4.x

Comments

@janbartel
Copy link
Contributor

Several jetty modules use the ServiceLoader these days, but they have not been updated to include the necessary manifest headers to ensure that the ServiceLoader will work in osgi.

Modules found so far that need attention:

  • jetty-xml
  • jetty-util
  • jetty-spring
@janbartel janbartel added this to the 9.4.x milestone Jan 30, 2018
@janbartel janbartel self-assigned this Jan 30, 2018
@janbartel
Copy link
Contributor Author

Depends on #2166 because spifly hardcodes use of asm 4 opcode, but the use of ServiceLoader in a static initializer requires asm 5 opcode.

janbartel added a commit that referenced this issue Jan 30, 2018
@janbartel
Issue #2164 correct manifest headers for ServiceLoader use in osgi
9eceba0 
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Jan 31, 2018
@janbartel
Issue #2164 Update websocket manifests for osgi and add test in osgi
5e1676e 
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Feb 1, 2018
@janbartel
Issue #2164 Add test for javax.websocket in osgi
3a84781 
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Feb 20, 2018
@janbartel
Issue #2164 correct manifest headers for ServiceLoader use in osgi
df012bb 
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Feb 20, 2018
@janbartel
Issue #2164 Update websocket manifests for osgi and add test in osgi
17f518f 
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Feb 20, 2018
@janbartel
Issue #2164 Add test for javax.websocket in osgi
1e84229 
Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel
Copy link
Contributor Author

Merged to jetty-9.4 and above.

@joakime joakime mentioned this issue Mar 6, 2018
Closed
@akurtakov
Copy link
Contributor

This reintroduces 1365 as the osgi.serviceloader.processor is not optional and breaks eclipse help system as per https://bugs.eclipse.org/bugs/show_bug.cgi?id=532294 . Would you please make the requirement optional?

@akurtakov
Copy link
Contributor

#1365

@joakime joakime reopened this Mar 22, 2018
@joakime joakime added the Bug For general bugs on Jetty side label Mar 22, 2018
@akurtakov
Copy link
Contributor

akurtakov commented Mar 22, 2018 •
edited

If we can get a release with this issue fixed it would allow the release for Java 10 comptability of Eclipse Platform to ship compatible Jetty too.

@mbooth101 mbooth101 mentioned this issue Mar 23, 2018
Merged
@mbooth101
Copy link
Member

@akurtakov I submitted a PR to fix this for Eclipse's use-case. See #2377

janbartel pushed a commit that referenced this issue Apr 3, 2018
@mbooth101 @janbartel
Make the requirement on "osgi.serviceloader.processor" optional (#2377)
c316cf1 
This allows Eclipse to continue to make use of jetty-* bundles
without requiring the presence of Apache Aries.

This fixes a problem introduced by the resolution to #2164 and
the same solution is used as in 10cdf16

See also the discussion at Eclipse:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=532294

Signed-off-by: Mat Booth <mat.booth@redhat.com>
janbartel added a commit that referenced this issue Apr 4, 2018
@janbartel
Issue #2164 Make osgi.serviceloader mostly optional
137d6d8 
Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel mentioned this issue Apr 4, 2018
Merged
janbartel added a commit that referenced this issue Apr 18, 2018
@janbartel
Issue #2164 Make osgi.serviceloader mostly optional (#2408)
0e88849 
Signed-off-by: Jan Bartel <janb@webtide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janbartel janbartel

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
9.4.x
Development

No branches or pull requests
4 participants
@joakime @janbartel @akurtakov @mbooth101