Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to create a WebSocketContainer passing HttpClient #5828

Closed
sbordet opened this issue Dec 18, 2020 · 1 comment · Fixed by #5952
Closed

Allow to create a WebSocketContainer passing HttpClient #5828

sbordet opened this issue Dec 18, 2020 · 1 comment · Fixed by #5952
Assignees

Comments

@sbordet
Copy link
Contributor

@sbordet sbordet commented Dec 18, 2020

Jetty version
10.0.x

Description
Client applications that want to use JSR WebSocket should be able to pass HttpClient to support TLS and have more configuration flexibility.

This is currently not possible because JavaxWebSocketClientContainer is in an internal package and not unconditionally exported.

However, JavaxWebSocketClientContainerProvider is accessible, so perhaps adding public static WebSocketContainer getContainer(HttpClient) will allow applications to create JSR WebSocket clients with the required flexibility.

@sbordet
Copy link
Contributor Author

@sbordet sbordet commented Dec 18, 2020

Furthermore, the JavaxWebSocketClientContainer(HttpClient httpClient) constructor should not change the name of the HttpClient, since it is provided externally and not owned by the client container.

@sbordet sbordet added this to To do in Jetty 10.0.1 via automation Dec 18, 2020
lachlan-roberts added a commit that referenced this issue Dec 23, 2020
…ntainerProvider

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Feb 15, 2021
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Feb 15, 2021
…lientContainer

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Jetty 10.0.1 automation moved this from To do to Done Feb 21, 2021
lachlan-roberts added a commit that referenced this issue Feb 21, 2021
…tHttpClient

Issue #5828 - allow HttpClient to be used with JavaxWebSocketClientContainerProvider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Jetty 10.0.1
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants