Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Durable Filters, Servlets and Listeners #5835

Closed
gregw opened this issue Dec 22, 2020 · 2 comments · Fixed by #6027
Closed

Review Durable Filters, Servlets and Listeners #5835

gregw opened this issue Dec 22, 2020 · 2 comments · Fixed by #6027

Comments

@gregw
Copy link
Contributor

@gregw gregw commented Dec 22, 2020

Jetty version

9.4.x

Description

Several issues have been seen with durable filters, servlets and listeners:

  • Filters, Servlets and Listeners added via the embedded API are assumed to be durable, however if they are added during starting phase, they should be assumed to be non durable
  • non durable ServletContextListeners are removed before the contextDestroyed event is called, so it is never called for those listeners
@gregw
Copy link
Contributor Author

@gregw gregw commented Dec 22, 2020

@lachlan-roberts anything else we discussed?

gregw added a commit that referenced this issue Dec 22, 2020
Filters, Servlets and Listeners are only durable if added prior to starting.
gregw added a commit that referenced this issue Dec 22, 2020
For non durable ServletContextListeners ensure that initialized is called if they are added during starting and that destroyed is called.
gregw added a commit that referenced this issue Dec 22, 2020
lachlan-roberts added a commit that referenced this issue Dec 23, 2020
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw added a commit that referenced this issue Dec 23, 2020
Update WebSocketUpgradeFilter to have durable configuration.
gregw added a commit that referenced this issue Dec 29, 2020
throw ISE for SCL added after init
@gregw gregw self-assigned this Mar 3, 2021
@gregw gregw added this to To do in Jetty 10.0.2/11.0.2 via automation Mar 3, 2021
@gregw
Copy link
Contributor Author

@gregw gregw commented Mar 3, 2021

Let's fix only in 10.

gregw added a commit that referenced this issue Mar 3, 2021
Fix #5835 Durable filters and servlets with a general ServletHandler cleanup
@gregw gregw closed this in #6027 Mar 22, 2021
Jetty 10.0.2/11.0.2 automation moved this from To do to Done Mar 22, 2021
gregw added a commit that referenced this issue Mar 22, 2021
Fix #5835 Durable filters and servlets with a general ServletHandler cleanup
update indexes after updating mapping
update mappings/indexes before destroyed listeners

Signed-off-by: Greg Wilkins <gregw@webtide.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants