Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache-Control header set by a filter is override by the value from DefaultServlet configuration #5977

Closed
olamy opened this issue Feb 17, 2021 · 1 comment · Fixed by #5978
Closed

Comments

@olamy
Copy link
Contributor

@olamy olamy commented Feb 17, 2021

In case some filter set the value of Cache-Control header then the DefaultServlet via ResourceService will override it if configured.

@olamy olamy self-assigned this Feb 17, 2021
@olamy olamy added the Bug label Feb 17, 2021
@olamy olamy added this to the 9.4.x milestone Feb 17, 2021
olamy added a commit that referenced this issue Feb 17, 2021
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
@olamy olamy changed the title cache-control header set by a filter is override by the value from DefaultServlet configuration Cache-Control header set by a filter is override by the value from DefaultServlet configuration Feb 17, 2021
@joakime joakime linked a pull request that will close this issue Feb 17, 2021
@joakime joakime added this to To do in Jetty 9.4.37 via automation Feb 17, 2021
@joakime joakime moved this from To do to In progress in Jetty 9.4.37 Feb 17, 2021
olamy added a commit that referenced this issue Feb 17, 2021
* Issue #5977 do not force Cache-Control header if already set

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
@olamy
Copy link
Contributor Author

@olamy olamy commented Feb 17, 2021

fixed by addfbe8

@olamy olamy closed this Feb 17, 2021
Jetty 9.4.37 automation moved this from In progress to Done Feb 17, 2021
olamy added a commit that referenced this issue Feb 17, 2021
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
olamy added a commit that referenced this issue Feb 23, 2021
 was partially fixed

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
olamy added a commit that referenced this issue Feb 23, 2021
…nse, Issue #5977 was partially fixed

Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
gregw added a commit that referenced this issue Feb 23, 2021
Improve efficiency for non wrapped response for cache-contro
gregw added a commit that referenced this issue Feb 23, 2021
Improve efficiency for non wrapped response for cache-contro
gregw added a commit that referenced this issue Feb 23, 2021
Improve efficiency for non wrapped response for cache-contro
gregw added a commit that referenced this issue Feb 23, 2021
Improve efficiency for non wrapped response for cache-contro
@gregw gregw added this to To do in Jetty 9.4.38 via automation Mar 25, 2021
@gregw gregw moved this from To do to Done in Jetty 9.4.38 Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants