Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Path resolution in XmlConfiguration #6021

Closed
joakime opened this issue Mar 2, 2021 · 0 comments · Fixed by #6022
Closed

Standardize Path resolution in XmlConfiguration #6021

joakime opened this issue Mar 2, 2021 · 0 comments · Fixed by #6022
Assignees

Comments

@joakime
Copy link
Member

@joakime joakime commented Mar 2, 2021

Jetty version
10.0.0

Java version
All

OS type/version
All

Description
Currently, due to the way we use <Set name="otherPath"><Property name="jetty.base" default="."/>/<Property name="jetty.other.path"/></Set> it's complicating how we can support arbitrary paths for the jetty.other.path property.

The introduction of new properties for absolute path and deep nesting to allow overrides/defaults/replacements is needlessly complicating the XML.

If we just used Path(base).resolve(configPath) we get support for all things (absolute, relative, windows, linux, server shares, etc. pretty much anything that Java and it's FileSystem can support, we can then support).

joakime added a commit that referenced this issue Mar 2, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime self-assigned this Mar 2, 2021
@joakime joakime added this to To do in Jetty 10.0.2/11.0.2 via automation Mar 2, 2021
joakime added a commit that referenced this issue Mar 2, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime linked a pull request that will close this issue Mar 2, 2021
joakime added a commit that referenced this issue Mar 3, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Mar 3, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Mar 3, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Mar 3, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Mar 3, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Mar 3, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Mar 3, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Mar 3, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime closed this in #6022 Mar 3, 2021
Jetty 10.0.2/11.0.2 automation moved this from To do to Done Mar 3, 2021
joakime added a commit that referenced this issue Mar 3, 2021
…solution

Issue #6021 - PoC for resolvePath within XmlConfiguration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant