Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SslConnection compacting #6082

Closed
gregw opened this issue Mar 22, 2021 · 2 comments · Fixed by #6083 or #6142
Closed

SslConnection compacting #6082

gregw opened this issue Mar 22, 2021 · 2 comments · Fixed by #6083 or #6142

Comments

@gregw
Copy link
Contributor

@gregw gregw commented Mar 22, 2021

From fixing #6072, it became apparent that the SslConnection compacts buffers frequently. Performance can be improved if compaction is only done when needed.

@gregw gregw added this to To do in Jetty 10.0.2/11.0.2 via automation Mar 22, 2021
gregw added a commit that referenced this issue Mar 22, 2021
Only compact when buffer is underflown.  Note that BufferUtil will also do a cheap "compact" when flipping empty buffers.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw added a commit that referenced this issue Mar 23, 2021
Only continue if compact creates more space

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw closed this in #6083 Mar 23, 2021
Jetty 10.0.2/11.0.2 automation moved this from To do to Done Mar 23, 2021
gregw added a commit that referenced this issue Mar 23, 2021
Fix #6082 Reduce SSL buffer compaction
Only compact when buffer is underflown.  Note that BufferUtil will also do a cheap "compact" when flipping empty buffers.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw
Copy link
Contributor Author

@gregw gregw commented Mar 23, 2021

This could be cherry picked back to 9 once it has proven stable in 10.

@gregw gregw reopened this Mar 23, 2021
Jetty 10.0.2/11.0.2 automation moved this from Done to In progress Mar 23, 2021
@gregw gregw removed this from In progress in Jetty 10.0.2/11.0.2 Mar 23, 2021
gregw added a commit that referenced this issue Mar 24, 2021
fix test timeout

Signed-off-by: Greg Wilkins <gregw@webtide.com>
sbordet added a commit that referenced this issue Apr 6, 2021
Fix #6082 Reduce SSL buffer compaction
Only compact when buffer is underflown.  Note that BufferUtil will also do a cheap "compact" when flipping empty buffers.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
(cherry picked from commit 96f707f)
sbordet added a commit that referenced this issue Apr 7, 2021
Fix #6082 Reduce SSL buffer compaction
Only compact when buffer is underflown.  Note that BufferUtil will also do a cheap "compact" when flipping empty buffers.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
(cherry picked from commit 96f707f)
@sbordet sbordet added this to To do in Jetty 9.4.40 via automation Apr 14, 2021
@sbordet sbordet moved this from To do to Done in Jetty 9.4.40 Apr 14, 2021
@sbordet sbordet linked a pull request that will close this issue Apr 14, 2021
@sbordet
Copy link
Contributor

@sbordet sbordet commented Apr 14, 2021

Fixed in Jetty 9 by #6142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
@gregw @sbordet and others