Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty start.jar always reports jetty.tag.version as master #6148

Closed
joakime opened this issue Apr 8, 2021 · 1 comment · Fixed by #6149
Closed

Jetty start.jar always reports jetty.tag.version as master #6148

joakime opened this issue Apr 8, 2021 · 1 comment · Fixed by #6149
Assignees
Labels

Comments

@joakime
Copy link
Member

@joakime joakime commented Apr 8, 2021

Jetty version
9.4.x+

Java version
All versions

OS type/version
All.

Description
When the start.jar --list-config is used, the following output is produced ...

--(snip)--
Jetty Environment:
-----------------
 jetty.version = 9.4.39.v20210325
 jetty.tag.version = master
--(snip)--

The jetty.tag.version always reports as master.
This should either be the tag name, or the build-number (git sha).

@joakime joakime added the Bug label Apr 8, 2021
@joakime joakime self-assigned this Apr 8, 2021
@joakime joakime added this to To do in Jetty 9.4.40 via automation Apr 8, 2021
joakime added a commit that referenced this issue Apr 8, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime moved this from To do to Review Pending in Jetty 9.4.40 Apr 8, 2021
@joakime joakime linked a pull request that will close this issue Apr 8, 2021
joakime added a commit that referenced this issue Apr 9, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Apr 12, 2021
Issue #6148 - update jetty.tag.version behavior
@joakime
Copy link
Member Author

@joakime joakime commented Apr 12, 2021

Merged PR #6149

@joakime joakime closed this Apr 12, 2021
Jetty 9.4.40 automation moved this from Review Pending to Done Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
@joakime and others