Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total timeout not enforced for queued requests #6254

Closed
sbordet opened this issue May 11, 2021 · 0 comments · Fixed by #6257 or #6258
Closed

Total timeout not enforced for queued requests #6254

sbordet opened this issue May 11, 2021 · 0 comments · Fixed by #6257 or #6258

Comments

@sbordet
Copy link
Contributor

@sbordet sbordet commented May 11, 2021

Jetty version
9.4.x

Description
The total timeout for requests that are queued in a HttpDestination is not always enforced.
Sending a request just before a previous queued one is about to expire resets the timeout of the already queued one.

@sbordet sbordet self-assigned this May 11, 2021
sbordet added a commit that referenced this issue May 11, 2021
Various code cleanups.
Renamed HttpDestination.TimeoutTask to RequestTimeouts for clarity.
Improved javadocs, code comments and logging.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue May 11, 2021
Fixed logic in HttpDestination.RequestTimeouts, where now a timeout
is scheduled only when the expiration time is less than the existing one.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet linked a pull request that will close this issue May 11, 2021
sbordet added a commit that referenced this issue May 11, 2021
Updates after review.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue May 11, 2021
Various code cleanups.
Renamed HttpDestination.TimeoutTask to RequestTimeouts for clarity.
Improved javadocs, code comments and logging.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue May 11, 2021
Fixed logic in HttpDestination.RequestTimeouts, where now a timeout
is scheduled only when the expiration time is less than the existing one.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue May 11, 2021
Updates after review.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue May 11, 2021
Fixed logic in HttpDestination.RequestTimeouts, where now a timeout
is scheduled only when the expiration time is less than the existing one.
Various code cleanups.
Renamed HttpDestination.TimeoutTask to RequestTimeouts for clarity.
Improved javadocs, code comments and logging.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
(cherry picked from commit 5f23689)
(cherry picked from commit da50e06)
(cherry picked from commit 88ac104)
sbordet added a commit that referenced this issue May 12, 2021
Fixed logic in HttpDestination.RequestTimeouts, where now a timeout
is scheduled only when the expiration time is less than the existing one.
Various code cleanups.
Renamed HttpDestination.TimeoutTask to RequestTimeouts for clarity.
Improved javadocs, code comments and logging.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
(cherry picked from commit 5f23689)
(cherry picked from commit da50e06)
(cherry picked from commit 88ac104)
@sbordet sbordet added this to To do in Jetty 9.4.41 via automation May 12, 2021
@sbordet sbordet moved this from To do to Done in Jetty 9.4.41 May 12, 2021
@sbordet sbordet added this to To do in Jetty 10.0.3/11.0.3 via automation May 19, 2021
@sbordet sbordet moved this from To do to Done in Jetty 10.0.3/11.0.3 May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant