Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2278 - making distribution pom not require tests #2281

Merged
merged 1 commit into from Mar 15, 2018
Merged

Issue #2278 - making distribution pom not require tests #2281

merged 1 commit into from Mar 15, 2018

Conversation

joakime
Copy link
Member

@joakime joakime commented Mar 5, 2018

  • Speculative fix to ensure that the users of the jetty-distribution
    do not require the test artifacts to utilize the tarball / zip files
  • Also disabled the snapshot repository as it causes false success

Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com

@joakime
Copy link
Member Author

joakime commented Mar 5, 2018

Testing the updated Eclipse IP check as well.

@joakime joakime requested a review from olamy March 5, 2018 23:56
@joakime
Copy link
Member Author

joakime commented Mar 6, 2018

(boggle)
The build for this PR failed in linux_jdk9 but not linux_jdk8 ??

[linux_jdk9] [INFO] -------------------------------------------------------------
[linux_jdk9] [ERROR] COMPILATION ERROR : 
[linux_jdk9] [INFO] -------------------------------------------------------------
[linux_jdk9] [ERROR] /home/jenkins/workspace/jetty.project_PR-2281-SEOX75DYNU7DCEJ5CMU4TMKH7JYGNBG5ETSVLKBIIIKSLOLMP4PQ/tests/test-integration/src/test/java/org/eclipse/jetty/test/HttpInputIntegrationTest.java:[48,38] package org.eclipse.jetty.http2.server does not exist
[linux_jdk9] [ERROR] /home/jenkins/workspace/jetty.project_PR-2281-SEOX75DYNU7DCEJ5CMU4TMKH7JYGNBG5ETSVLKBIIIKSLOLMP4PQ/tests/test-integration/src/test/java/org/eclipse/jetty/test/HttpInputIntegrationTest.java:[98,101] cannot find symbol
[linux_jdk9]   symbol:   class HTTP2CServerConnectionFactory
[linux_jdk9]   location: class org.eclipse.jetty.test.HttpInputIntegrationTest

@olamy
Copy link
Contributor

olamy commented Mar 6, 2018

linux_jdk9 is probably faster to fail :-)

@olamy
Copy link
Contributor

olamy commented Mar 6, 2018

@joakime fix here olamy@78142e3

- Speculative fix to ensure that the users of the jetty-distribution
  do not require the test artifacts to utilize the tarball / zip files
- Also disabled the snapshot repository as it causes false success
- Adding now unreferenced dependency

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime merged commit 3f17f78 into eclipse:jetty-9.4.x Mar 15, 2018
@joakime joakime deleted the issue-2278-dist-test-dep branch March 15, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants