Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4444 - Connection timeout intermittently when using jetty 9.4… #4446

Merged
merged 3 commits into from Jan 17, 2020

Conversation

@sbordet
Copy link
Contributor

sbordet commented Dec 26, 2019

….25.

#4444.

Fixed handling of encrypted bytes to write in
needsFillInterest() when the TLS handshake status
is NOT_HANDSHAKING.

Signed-off-by: Simone Bordet simone.bordet@gmail.com

Fixed handling of encrypted bytes to write in
needsFillInterest() when the TLS handshake status
is NOT_HANDSHAKING.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet requested a review from gregw Dec 26, 2019
@sbordet

This comment has been minimized.

Copy link
Contributor Author

sbordet commented Dec 26, 2019

@gregw I pushed a fix, but hard to write a test case.

Fixed write in doShutdownOutput() by updating the state before the write,
so that needsFillInterest() can check whether to also do a write or not.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@gregw
gregw approved these changes Jan 17, 2020
Copy link
Contributor

gregw left a comment

LGTM - pity this missed 9.4.26 (or did it @joakime ?)

@sbordet sbordet added this to In progress in Jetty 9.4.26 via automation Jan 17, 2020
@sbordet

This comment has been minimized.

Copy link
Contributor Author

sbordet commented Jan 17, 2020

@joakime I agree that this change should be in 9.4.26. Can you restage?

@sbordet sbordet merged commit 692d901 into jetty-9.4.x Jan 17, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-merge This commit is being built
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
Jetty 9.4.26 automation moved this from In progress to Done Jan 17, 2020
@sbordet sbordet deleted the jetty-9.4.x-4444-tls_idle_timeout branch Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Jetty 9.4.26
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.