Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4383 - Minimal NPE prevention on MultiPart #4479

Merged
merged 2 commits into from Jan 15, 2020

Conversation

@joakime
Copy link
Member

joakime commented Jan 15, 2020

Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com

#4383

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime requested a review from lachlan-roberts Jan 15, 2020
@joakime joakime added this to In progress in Jetty 9.4.26 via automation Jan 15, 2020
@joakime joakime moved this from In progress to Review in progress in Jetty 9.4.26 Jan 15, 2020
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Copy link
Member

lachlan-roberts left a comment

Looks good, it does fix the NPE.
Leaves the other multipart issues associated with this which will be fixed in a continuation of #4388 for Jetty-10.

Jetty 9.4.26 automation moved this from Review in progress to Reviewer approved Jan 15, 2020
@joakime joakime merged commit b75cf1c into jetty-9.4.x Jan 15, 2020
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
Jetty 9.4.26 automation moved this from Reviewer approved to Done Jan 15, 2020
@joakime joakime deleted the jetty-9.4.x-4383-npe-multipart branch Jan 15, 2020
@joakime joakime restored the jetty-9.4.x-4383-npe-multipart branch Jan 16, 2020
@joakime joakime deleted the jetty-9.4.x-4383-npe-multipart branch Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Jetty 9.4.26
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.