Issue #5018 - add WebSocketClient UpgradeRequest timeout to jetty 10 #5031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
|
This failed CI? But no problems changing API like this in a Beta.... but last chance as we are going final real soon now! |
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
sbordet
requested changes
Jul 13, 2020
...cket-jetty-client/src/main/java/org/eclipse/jetty/websocket/client/ClientUpgradeRequest.java
Show resolved
Hide resolved
...cket-jetty-client/src/main/java/org/eclipse/jetty/websocket/client/ClientUpgradeRequest.java
Show resolved
Hide resolved
...cket-jetty-client/src/main/java/org/eclipse/jetty/websocket/client/ClientUpgradeRequest.java
Show resolved
Hide resolved
...websocket-jetty-client/src/main/java/org/eclipse/jetty/websocket/client/WebSocketClient.java
Show resolved
Hide resolved
...-client/src/main/java/org/eclipse/jetty/websocket/client/impl/JettyClientUpgradeRequest.java
Outdated
Show resolved
Hide resolved
...-client/src/main/java/org/eclipse/jetty/websocket/client/impl/JettyClientUpgradeRequest.java
Outdated
Show resolved
Hide resolved
…5018-WebSocketClientRequestTimeout Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
sbordet
requested changes
Jul 14, 2020
...cket-jetty-client/src/main/java/org/eclipse/jetty/websocket/client/ClientUpgradeRequest.java
Show resolved
Hide resolved
sbordet
approved these changes
Jul 15, 2020
sbordet
approved these changes
Jul 15, 2020
lachlan-roberts
deleted the
jetty-10.0.x-5018-WebSocketClientRequestTimeout
branch
joakime
added a commit
that referenced
this pull request
Aug 21, 2020
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for Jetty-10 based off PR #5024 for issue #5018.
I have changed the signature for
WebSocketClient.connect()back to what it was in jetty 9.4.x, it is now taking aClientUpgradeRequestand not the apiUpgradeRequest. This is an API change so not sure if that is still okay now the beta release is out.I don't think we want the timeout on the
org.eclipse.jetty.websocket.api.UpgradeRequestas it is only usable for the clients upgrade request anyway.