Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the JavaxWebSocketClientContainer.getContainer(HttpClient) method static. #6107

Merged

Conversation

@lachlan-roberts
Copy link
Member

@lachlan-roberts lachlan-roberts commented Mar 26, 2021

  • Make the JavaxWebSocketClientContainer.getContainer(HttpClient) method static.
  • Introduce utility methods to add and remove beans from containers.
…tContainerProvider.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts requested a review from gregw Mar 26, 2021
Copy link
Contributor

@gregw gregw left a comment

Shouldn't your websocket stuff use these new methods?

@lachlan-roberts
Copy link
Member Author

@lachlan-roberts lachlan-roberts commented Mar 26, 2021

@gregw the only place the method was used is from the no args getContainer() method of JavaxWebSocketClientContainerProvider. There are no other usages to update.

…lient) method.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
gregw approved these changes Mar 26, 2021
@lachlan-roberts lachlan-roberts merged commit b68a5fe into jetty-10.0.x Mar 26, 2021
2 checks passed
@lachlan-roberts lachlan-roberts deleted the jetty-10.0.x-JavaxWebSocketContainerProvider branch Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants