Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #6277 Better handling of exceptions thrown in sessionDestroyed #6278

Merged

Conversation

@janbartel
Copy link
Contributor

@janbartel janbartel commented May 14, 2021

Closes #6277

Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel self-assigned this May 14, 2021
@janbartel janbartel added this to In progress in Jetty 10.0.3/11.0.3 via automation May 14, 2021
@janbartel janbartel requested a review from gregw May 14, 2021
gregw
gregw previously approved these changes May 14, 2021
Copy link
Contributor

@gregw gregw left a comment

LGTM

Jetty 10.0.3/11.0.3 automation moved this from In progress to Reviewer approved May 14, 2021
@joakime
Copy link
Member

@joakime joakime commented May 15, 2021

Somehow this broke the PushBuilder tests ???

Signed-off-by: Jan Bartel <janb@webtide.com>
Jetty 10.0.3/11.0.3 automation moved this from Reviewer approved to Review in progress May 15, 2021
gregw
gregw approved these changes May 15, 2021
Jetty 10.0.3/11.0.3 automation moved this from Review in progress to Reviewer approved May 15, 2021
@janbartel janbartel merged commit cd6462a into jetty-10.0.x May 15, 2021
2 checks passed
Jetty 10.0.3/11.0.3 automation moved this from Reviewer approved to Done May 15, 2021
@janbartel janbartel deleted the jetty-10.0.x-6277-session-destroy-listener-exceptions branch May 15, 2021
janbartel added a commit that referenced this issue May 16, 2021
…6278)

* Issue #6277 Better handling of exceptions thrown in sessionDestroyed

Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue May 16, 2021
…6278) (#6279)

* Issue #6277 Better handling of exceptions thrown in sessionDestroyed

Signed-off-by: Jan Bartel <janb@webtide.com>
@joakime
Copy link
Member

@joakime joakime commented Jun 24, 2021

@chaos-ui this fix is already present for Jetty 10.0.3 and Jetty 11.0.3 releases. (been there 3 releases each so far)

The backport for 9.4.43 took longer to test, and will show up in Jetty 9.4.43 (due out soon-ish, pay attention to Issue #6450)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

3 participants