Skip to content
Browse files

Fix tests for Ant task "git-clone"

If project.init() isn't called GitCloneTaskTest fails when started from
Eclipse, according to [1] calling init() is necessary to properly
initialize the Ant project programmatically.

Always set the destination folder in order to ensure that all test
resources are created under the project's target folder and do not
pollute the project's source tree with test data.

[1]
http://ant.1045680.n5.nabble.com/project-createTask-not-working-with-ant-1-8-2-td3385716.html

Change-Id: Icbeb62680b018a92673faa58828b5e850564c7a8
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
  • Loading branch information...
1 parent 6189a68 commit ee90d6afba1946345386efcee8b14a017e0eb01c @msohn msohn committed Apr 2, 2012
Showing with 6 additions and 5 deletions.
  1. +6 −5 org.eclipse.jgit.ant.test/src/org/eclipse/jgit/ant/tasks/GitCloneTaskTest.java
View
11 org.eclipse.jgit.ant.test/src/org/eclipse/jgit/ant/tasks/GitCloneTaskTest.java
@@ -45,6 +45,7 @@
import static org.junit.Assert.assertTrue;
import java.io.File;
+import java.io.IOException;
import org.apache.tools.ant.BuildException;
import org.apache.tools.ant.DefaultLogger;
@@ -60,13 +61,17 @@
private GitCloneTask task;
private Project project;
+ private File dest;
@Before
- public void before() {
+ public void before() throws IOException {
project = new Project();
+ project.init();
enableLogging();
project.addTaskDefinition("git-clone", GitCloneTask.class);
task = (GitCloneTask) project.createTask("git-clone");
+ dest = createTempFile();
+ task.setDest(dest);
}
@Test(expected = BuildException.class)
@@ -97,8 +102,6 @@ public void shouldCloneAValidGitRepository() throws Exception {
FileRepository repo = createBareRepository();
File directory = repo.getDirectory();
task.setUri("file://" + directory);
- File dest = createTempFile();
- task.setDest(dest);
task.execute();
assertTrue(RepositoryCache.FileKey.isGitRepository(new File(dest, ".git"), FS.DETECTED));
@@ -110,8 +113,6 @@ public void shouldCreateABareCloneOfAValidGitRepository() throws Exception {
File directory = repo.getDirectory();
task.setUri("file://" + directory);
task.setBare(true);
- File dest = createTempFile();
- task.setDest(dest);
task.execute();
assertTrue(RepositoryCache.FileKey.isGitRepository(dest, FS.DETECTED));

0 comments on commit ee90d6a

Please sign in to comment.
Something went wrong with that request. Please try again.