New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityManagerSession fix missing rollback #131

Merged
merged 1 commit into from Dec 1, 2016

Conversation

Projects
None yet
4 participants
@riccardomodanese
Contributor

riccardomodanese commented Nov 30, 2016

Signed-off-by: riccardomodanese riccardo.modanese@eurotech.com

fix #130

@eclipsewebmaster

This comment has been minimized.

Collaborator

eclipsewebmaster commented Nov 30, 2016

@Coduz

Coduz approved these changes Nov 30, 2016

Hi Riccardo,

the only thing that I would add is to throw an exception when calling em.close() if the transaction has not being commited or rolled back. This would prevent stale transactions.

Regards,

Albeto

[130] - EntityManagerSession transacted method implementation
Signed-off-by: riccardomodanese <riccardo.modanese@eurotech.com>
@Coduz

Coduz approved these changes Dec 1, 2016

@stefanomorson stefanomorson changed the title from [130] - EntityManagerSession fix missing rollback to EntityManagerSession fix missing rollback Dec 1, 2016

@stefanomorson stefanomorson merged commit 1d62241 into develop Dec 1, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
ip-validation
Details

@stefanomorson stefanomorson deleted the fix-entityManagerRollback branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment