Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of kapua-device-management-all-* module #1915

Merged
merged 1 commit into from Sep 11, 2018

Conversation

@Coduz
Copy link
Contributor

Coduz commented Jul 31, 2018

This PR is a proposal to introduce the kapua-device-management-all-api and kapua-device-management-all-internal that groups all device management modules to make them easier to import from modules that depends on them all (like kapua-console-web and kapua-rest-api-web)

Related Issue
No related issue

Description of the solution adopted
Created modules:

  • kapua-device-management-all-api
    • kapua-device-management-asset-api
    • kapua-device-management-bundle-api
    • kapua-device-management-configuration-api
    • kapua-device-management-command-api
    • kapua-device-management-packages-api
    • kapua-device-management-request-api
  • kapua-device-management-all-internal
    • kapua-device-management-asset-internal
    • kapua-device-management-bundle-internal
    • kapua-device-management-configuration-internal
    • kapua-device-management-command-internal
    • kapua-device-management-packages-internal
    • kapua-device-management-request-internal

Replaced dependencies with these modules

Screenshots
None

Any side note on the changes made
None

@Coduz Coduz force-pushed the chng-addDeviceManagementAllModule branch from 02759fc to 148a9a3 Aug 6, 2018
@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 6, 2018

Codecov Report

Merging #1915 into develop will increase coverage by 4.41%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1915      +/-   ##
=============================================
+ Coverage      51.94%   56.36%   +4.41%     
- Complexity      1519     1536      +17     
=============================================
  Files           1146     1048      -98     
  Lines          26790    25556    -1234     
  Branches        2278     2252      -26     
=============================================
+ Hits           13917    14404     +487     
+ Misses         11936    10217    -1719     
+ Partials         937      935       -2
Impacted Files Coverage Δ Complexity Δ
...va/org/eclipse/kapua/kura/simulator/Simulator.java 66.66% <0%> (-7.41%) 0% <0%> (ø)
...lipse/kapua/kura/simulator/MqttAsyncTransport.java 55.55% <0%> (-4.17%) 0% <0%> (ø)
...ment/command/internal/DeviceCommandOutputImpl.java
...on/PackageUninstallExecuteManagementException.java
...ackages/message/internal/PackageAppProperties.java
...l/exception/CommandExecuteManagementException.java
...bundle/message/internal/BundleResponseMessage.java
.../bundle/message/internal/BundleRequestMessage.java
...nal/message/request/GenericRequestChannelImpl.java
...d/internal/DeviceCommandManagementServiceImpl.java
... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dd9406...2d0ef83. Read the comment docs.

@Coduz Coduz force-pushed the chng-addDeviceManagementAllModule branch from 148a9a3 to ca01724 Aug 28, 2018
@Coduz Coduz force-pushed the chng-addDeviceManagementAllModule branch from ca01724 to e5dd201 Sep 4, 2018
Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the chng-addDeviceManagementAllModule branch from e5dd201 to 2d0ef83 Sep 6, 2018
@Coduz Coduz merged commit 84c3805 into develop Sep 11, 2018
5 checks passed
5 checks passed
codecov/patch Coverage not affected when comparing 0dd9406...2d0ef83
Details
codecov/project 56.36% (+4.41%) compared to 0dd9406
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
ip-validation
Details
@Coduz Coduz added this to Done in 1.1.0 via automation Sep 11, 2018
@Coduz Coduz deleted the chng-addDeviceManagementAllModule branch Sep 11, 2018
@Coduz Coduz added the enhancement label Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1.1.0
  
Done
1 participant
You can’t perform that action at this time.