Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job target error message #2342

Merged
merged 3 commits into from Mar 26, 2019

Conversation

@Coduz
Copy link
Contributor

Coduz commented Jan 29, 2019

This PR adds the statusMessage field to the JobTarget which can be used to show useful informations about the processing of the target.

Related Issue
None

Description of the solution adopted
Added new field to the JobTarget entity and used the Exception.getMessage() to populate in case of an Exception occurring during processing

Screenshots
None

Any side note on the changes made
This PR is based on feature-concurrentJobsExecution which has its own PR #2323

@Coduz Coduz added the enhancement label Jan 29, 2019
@Coduz Coduz added this to To Do in 1.1.0 via automation Jan 29, 2019
@Coduz Coduz mentioned this pull request Jan 29, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #2342 into feature-concurrentJobsExecution will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                          Coverage Diff                          @@
##             feature-concurrentJobsExecution    #2342      +/-   ##
=====================================================================
- Coverage                              56.09%   56.09%   -0.01%     
  Complexity                              1501     1501              
=====================================================================
  Files                                   1068     1068              
  Lines                                  25831    25833       +2     
  Branches                                2322     2322              
=====================================================================
  Hits                                   14491    14491              
- Misses                                 10358    10360       +2     
  Partials                                 982      982
Impacted Files Coverage Δ Complexity Δ
...g/eclipse/kapua/service/job/targets/JobTarget.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ua/service/job/targets/internal/JobTargetImpl.java 57.14% <0%> (-6.86%) 10 <0> (ø)
...ervice/job/execution/internal/JobExecutionDAO.java 81.25% <0%> (ø) 6% <0%> (ø) ⬇️
...ua/commons/model/AbstractKapuaUpdatableEntity.java 81.39% <0%> (ø) 0% <0%> (ø) ⬇️
...ob/execution/internal/JobExecutionCreatorImpl.java 81.81% <0%> (ø) 6% <0%> (ø) ⬇️
...rvice/job/execution/internal/JobExecutionImpl.java 50% <0%> (+1.61%) 9% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 935ae58...c041650. Read the comment docs.

@Coduz Coduz force-pushed the feature-jobTargetErrorMessage branch 3 times, most recently from 2761087 to feafd7e Feb 5, 2019
@Coduz Coduz force-pushed the feature-jobTargetErrorMessage branch from feafd7e to b6df775 Feb 15, 2019
@Coduz Coduz changed the base branch from develop to feature-concurrentJobsExecution Feb 15, 2019
@Coduz Coduz force-pushed the feature-concurrentJobsExecution branch from fe4f2ef to 8b65c89 Mar 4, 2019
@Coduz Coduz force-pushed the feature-jobTargetErrorMessage branch from b6df775 to 14da2a3 Mar 4, 2019
@Coduz Coduz force-pushed the feature-concurrentJobsExecution branch from 8b65c89 to 734b9d3 Mar 22, 2019
@Coduz Coduz force-pushed the feature-jobTargetErrorMessage branch from 14da2a3 to 8ae6320 Mar 22, 2019
@Coduz Coduz force-pushed the feature-concurrentJobsExecution branch from 734b9d3 to efe7678 Mar 25, 2019
@Coduz Coduz force-pushed the feature-jobTargetErrorMessage branch from 8ae6320 to 50d26c6 Mar 25, 2019
Coduz added 3 commits Jan 23, 2019
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the feature-jobTargetErrorMessage branch from 50d26c6 to c041650 Mar 26, 2019
@Coduz Coduz changed the base branch from feature-concurrentJobsExecution to develop Mar 26, 2019
@Coduz Coduz merged commit 2362a6f into develop Mar 26, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
1.1.0 automation moved this from To Do to Done Mar 26, 2019
@Coduz Coduz deleted the feature-jobTargetErrorMessage branch Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1.1.0
  
Done
1 participant
You can’t perform that action at this time.