Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgraded Slf4j-api version from 25.0 to 26.0 - CVE-2018-8088 #2627
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Jun 24, 2019
•
Codecov Report
@@ Coverage Diff @@
## develop #2627 +/- ##
==============================================
+ Coverage 0.82% 50.05% +49.22%
- Complexity 5 2453 +2448
==============================================
Files 992 959 -33
Lines 28134 27640 -494
Branches 2308 2269 -39
==============================================
+ Hits 233 13836 +13603
+ Misses 27884 12826 -15058
- Partials 17 978 +961
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Coduz commentedJun 24, 2019
•
edited
The PR bumps the version of Slf4j-api and bridging implementations to 1.7.26
Related Issue
None
Description of the solution adopted
Bumped to the last version available.
Full CQ required
slf4j-api: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20264
jcl-over-slf4j: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20265
log4j-over-slf4j: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20266
jul-to-slf4j: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20267
Screenshots
None
Any side note on the changes made
Grouped dependencies and add some comments.