Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various permission fixes in backend services #2664

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@lorthirk
Copy link
Contributor

lorthirk commented Jul 25, 2019

This PR fixes a few wrong permission check in various backend services

@lorthirk lorthirk requested a review from Coduz Jul 25, 2019
@lorthirk lorthirk added this to To Do in 1.1.0 via automation Jul 25, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #2664 into develop will decrease coverage by 0.48%.
The diff coverage is 93.1%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2664      +/-   ##
=============================================
- Coverage      53.06%   52.58%   -0.49%     
- Complexity      2828     2845      +17     
=============================================
  Files           1024     1024              
  Lines          28820    29534     +714     
  Branches        2330     2410      +80     
=============================================
+ Hits           15293    15529     +236     
- Misses         12482    12968     +486     
+ Partials        1045     1037       -8
Impacted Files Coverage Δ Complexity Δ
...apua/job/engine/jbatch/JobEngineServiceJbatch.java 26.85% <0%> (ø) 4 <0> (ø) ⬇️
...e/certificate/internal/CertificateServiceImpl.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/service/account/internal/AccountServiceImpl.java 78.4% <100%> (+1.08%) 0 <0> (ø) ⬇️
...pua/service/account/steps/AccountServiceSteps.java 24.33% <100%> (+2.41%) 25 <4> (+4) ⬆️
...ob/execution/internal/JobExecutionServiceImpl.java 100% <100%> (ø) 15 <0> (ø) ⬇️
...egistry/event/internal/DeviceEventServiceImpl.java 61.22% <0%> (-22.45%) 8% <0%> (-4%)
...device/registry/event/internal/DeviceEventDAO.java 68.75% <0%> (-18.75%) 2% <0%> (-2%)
...nnection/internal/DeviceConnectionServiceImpl.java 45.56% <0%> (-15.19%) 10% <0%> (-3%)
...ice/device/registry/steps/DeviceRegistrySteps.java 27.84% <0%> (-10.59%) 59% <0%> (-15%)
...istry/connection/internal/DeviceConnectionDAO.java 78.94% <0%> (-10.53%) 4% <0%> (-1%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69c4a42...2047f10. Read the comment docs.

@lorthirk lorthirk force-pushed the lorthirk:fix-servicePermissions branch from 8b4c318 to 4b240bf Jul 29, 2019
@Coduz
Coduz approved these changes Jul 29, 2019
@Coduz Coduz added this to Backport in 1.0.7 via automation Jul 29, 2019
@lorthirk lorthirk force-pushed the lorthirk:fix-servicePermissions branch 3 times, most recently from c491ca3 to 2047f10 Jul 29, 2019
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk force-pushed the lorthirk:fix-servicePermissions branch from 2047f10 to 25199e6 Jul 30, 2019
@Coduz
Coduz approved these changes Jul 30, 2019
@Coduz Coduz merged commit aa57b90 into eclipse:develop Jul 30, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
1.1.0 automation moved this from To Do to Done Jul 30, 2019
@Coduz Coduz moved this from Backport to Dome in 1.0.7 Jul 30, 2019
@Coduz Coduz added the bug label Jul 30, 2019
@lorthirk lorthirk deleted the lorthirk:fix-servicePermissions branch Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1.1.0
  
Done
1.0.7
  
Done
2 participants
You can’t perform that action at this time.