Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Trigger creation from child accounts #2724

Merged
merged 3 commits into from Sep 26, 2019

Conversation

@Coduz
Copy link
Contributor

Coduz commented Sep 25, 2019

This PR solves an issue introduced with PR #2600 .

After the merge, child account where no longer able to create any of the triggers, no matter what was the type.

Related Issue
This PR is related to changes in #2600

Description of the solution adopted
Fixed the piece of code that was retrieving the TriggerDefinition on TriggerService.create arguments checks.

Screenshots
None

Any side note on the changes made
Added @NotNull and @Nullable annotation to ServiceDAO.

Coduz added 3 commits Sep 25, 2019
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz added the bug label Sep 25, 2019
@Coduz Coduz requested a review from lorthirk Sep 25, 2019
@Coduz Coduz added this to To Do in 1.1.0 via automation Sep 25, 2019
@Coduz Coduz merged commit c325e25 into eclipse:develop Sep 26, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
1.1.0 automation moved this from To Do to Done Sep 26, 2019
@Coduz Coduz deleted the Coduz:fix-triggerCreateForChildAccounts branch Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1.1.0
  
Done
2 participants
You can’t perform that action at this time.