Documentation update #664
Merged
Documentation update #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse#659 Also clarifies jwt token naming for server and need to specify servername for tls
lukasmittag
approved these changes
Sep 21, 2023
SebastianSchildt
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Content-wise looks good to me.
I noticed, NOTICE.md might need to go away eventually, as it is not really current, and we are doing the Dashfiles in release and BOMs in the artifacts. But for no taking the editorial changes
This also means the logic in #661 is fine, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #659
Also clarifies jwt token naming for server and need to specify servername for tls
How to check links is described as part of release process at https://github.com/eclipse/kuksa.val/wiki/Release-Process#checking-links, I just improved it a bit.