Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Intel UP2 support with CentOS 7 #2093
3 times, most recently
May 9, 2018
I don't see anything which speaks against merging that now. It doesn't change Kura itself, just adds a new distribution profile. And letting the PR wait and longer, only causes more trouble later on when it has to be re-based and possible conflicts being resolved.
And I also don't really understand what you mean by proper QA validation at this point. That is normally done right before the release of Kura. And when Kura enters that phase, then changes like that won't get merged as they are deemed too risky to be merged. At least that was the argument in the past.
So unless anything speaks against merging this, then I would say, merge it now.
Of course I have no issue supporting CentOS. I think it is a nice addition. I just didn't understand starting here, since unlike the Raspberry Pi, the UP2 ships with an installed OS. I will create a separate PR for Ubuntu support, since I assume that will be the simplest path for new Kura/UP2 users.
Since this doesn't impact the framework directly, only adds a new distribution, I think we can merge. If we find issues we can create separate issues. I can test this after I have tested the default Ubuntu installation. @ctron did you want to make any changes before I merge?