fix: web UI bug where invalid component could not be deleted. #4310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What it looks like now with the fix Screen.Recording.2022-12-16.at.6.05.41.PM.mov |
mattdibi
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #4305
Description of the solution adopted: Web UI throws an error when you try to apply a wire graph with an invalid component. the issue is this error is present when trying to delete this wire graph as well.
check if the invalid component is going to be deleted (not active), before adding It to the list of invalid components so the error is not thrown.
Screenshots: n/a
Any side note on the changes made: n/a