Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing elements of an existing dependency got broken when inserting artifactId from CA #276

Closed
vrubezhny opened this issue Feb 25, 2022 · 1 comment

Comments

@vrubezhny
Copy link
Contributor

Steps to reproduce:

  • Consider editing Maven Project like the following:
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
  <modelVersion>4.0.0</modelVersion>
  <artifactId>foo-child</artifactId>
  <packaging>pom</packaging>
  <name>FOO Child</name>
  <dependencies>
	<dependency>
		<artifactId>org.ecl|</artifactId>
	</dependency>
  </dependencies>
</project>
  • Place the cursor in text instead of "|" character and press Ctrl-Space to invoke the content assistant
  • Continue typing characters, for example ipse.lem in order to make org.eclipse.lemminx artifact to be the first selected proposal, then insert the selected proposal
  • See the proposal inserted breaking the existing code:
	<dependency>
		<groupId>org.eclipse.lemminx</groupId>
		<artifactId>org.eclipse.lemminx</art
		<version>0.19.1</version>ifactId>
	</dependency>
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Mar 3, 2022
…inserting artifactId from CA eclipse#276

Issue: eclipse#276

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@vrubezhny vrubezhny changed the title Existing elements of an existing artifact dependency got broken when inserting artifactId from CA Existing elements of an existing dependency got broken when inserting artifactId from CA Mar 3, 2022
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue Mar 11, 2022
…tem.

Allows to create the complition items with additional text edits and validate
the additional text edts in completion items. Required for lemminx-maven's tests.

Issue:  eclipse/lemminx-maven#276

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue Mar 11, 2022
…tem.

Allows to create the completion items with additional text edits and validate
the additional text edts in completion items. Required for lemminx-maven's tests.

Issue:  eclipse/lemminx-maven#276

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Mar 11, 2022
… artifactId from CA eclipse#276

A complimentary fix for `<version/>` element inserted by <artidactId/> CA proposal

Issue: eclipse#276

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
angelozerr pushed a commit to eclipse/lemminx that referenced this issue Mar 11, 2022
…tem.

Allows to create the completion items with additional text edits and validate
the additional text edts in completion items. Required for lemminx-maven's tests.

Issue:  eclipse/lemminx-maven#276

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Mar 11, 2022
… artifactId from CA eclipse#276

A complimentary fix for `<version/>` element inserted by <artidactId/> CA proposal

Issue: eclipse#276

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Mar 11, 2022
…erting artifactId from CA eclipse#276

A JUnit test for the issue.

Issue: eclipse#276

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@vrubezhny
Copy link
Contributor Author

The main fix is made in LSP4E: eclipse/lsp4e#89
The PR #285 contains additional fix for ` element in CA
The PR #286 contains new JUnit test cases made for the issue (depends on lemminx project PR - eclipse/lemminx#1186)

mickaelistria pushed a commit that referenced this issue Mar 14, 2022
… artifactId from CA #276

A complimentary fix for `<version/>` element inserted by <artidactId/> CA proposal

Issue: #276

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Sep 27, 2022
…erting artifactId from CA eclipse#276

A JUnit test for the issue.

Issue: eclipse#276

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit that referenced this issue Oct 3, 2022
…erting artifactId from CA #276

A JUnit test for the issue.

Issue: #276

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant