Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSLC Configuration Context support #69

Merged

Conversation

@cenobyte321
Copy link
Contributor

commented Jul 31, 2019

An approach to add support for Configuration Context in OSLC4J Client requests and OSLC queries.

cenobyte321 added some commits Jul 31, 2019

Enable Configuration-Context Header in OslcClient and oslc_config.con…
…text param in Query Capability

Signed-off-by: Luis Armando Ramirez <aramirezagu@gmail.com>
Removed the import all
Signed-off-by: Luis Armando Ramirez <aramirezagu@gmail.com>
Removed unused import
Signed-off-by: Luis Armando Ramirez <aramirezagu@gmail.com>
Changed hard-coded Header strings to constant
Signed-off-by: Luis Armando Ramirez <aramirezagu@gmail.com>
Fixed wrong assignment
Signed-off-by: Luis Armando Ramirez <aramirezagu@gmail.com>
@berezovskyi

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

Thanks Luis, I will take a look at it today! 👏

@berezovskyi
Copy link
Member

left a comment

Thanks for a PR! I think the best way is to integrate https://docs.oracle.com/javaee/7/api/javax/ws/rs/client/ClientRequestFilter.html filters but until someone has time to fix this fundamentally, your code seems to do the job perfectly.

Please see my comments inside. Also, please make sure to sign the ECA https://www.eclipse.org/legal/ECA.php. Let's see also what @jamsden says.

Incorporated changes based on Andrew's feedback
Signed-off-by: Luis Armando Ramirez <aramirezagu@gmail.com>

@cenobyte321 cenobyte321 force-pushed the cenobyte321:oslc-configuration-context-support branch 4 times, most recently from 552e19d to 3502ed8 Aug 1, 2019

Small indentation fix
Signed-off-by: Luis Armando Ramirez <aramirezagu@gmail.com>

@cenobyte321 cenobyte321 force-pushed the cenobyte321:oslc-configuration-context-support branch from 3502ed8 to c8bf0c9 Aug 1, 2019

@berezovskyi

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Looks good, Luis! We can merge this as soon as you sign the ECA. You will need to register an Eclipse account for that. Thanks a lot for the contribution!

@cenobyte321 cenobyte321 force-pushed the cenobyte321:oslc-configuration-context-support branch from c8bf0c9 to 25f624c Aug 2, 2019

@cenobyte321

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

Looks good, Luis! We can merge this as soon as you sign the ECA. You will need to register an Eclipse account for that. Thanks a lot for the contribution!

My pleasure! I just signed the ECA and signed the commits of this pull request.

@berezovskyi berezovskyi merged commit ddfd8a8 into eclipse:master Aug 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
@berezovskyi

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

@cenobyte321 thanks for your first contribution to Lyo! Merged to master.

isccarrasco added a commit to isccarrasco/lyo.client that referenced this pull request Aug 8, 2019

OSLC Configuration Context support (eclipse#69)
* Enable Configuration-Context Header in OslcClient and oslc_config.context param in Query Capability
* Changed hard-coded Header strings to constant

Signed-off-by: Luis Armando Ramirez <aramirezagu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.