New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 533213 - rdf:Seq deserialization in JMH contains no elements #14

Merged
merged 4 commits into from Jun 15, 2018

Conversation

Projects
None yet
4 participants
@neormx
Copy link
Contributor

neormx commented May 29, 2018

No description provided.

@eclipsewebmaster

This comment has been minimized.

Copy link

eclipsewebmaster commented May 29, 2018

Bug 533213 - rdf:Seq deserialization in JMH contains no elements
Change-Id: Ieaa59912148e26ae943794f2201212f269b90474
Signed-off-by: Ricardo J Herrera <neormx@gmail.com>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi

This comment has been minimized.

Copy link
Member

berezovskyi commented May 31, 2018

@jamsden @jadelkhoury @yashkhatri can anyone of you give me a +1 too? Just wanted a second opinion.

@jadelkhoury
Copy link
Contributor

jadelkhoury left a comment

+1
In future reviews, I wonder if it helps if the contributor (especially if is is a committer) can comment on their changes here on GitHub. This would help a reviewer.
(For example, many changes can be simply about formatting, and hence can be ignored. Also, contributor can explain what/why the change was made)

@@ -28,6 +28,7 @@
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<jena.version>3.6.0</jena.version>

This comment has been minimized.

@jadelkhoury

jadelkhoury May 31, 2018

Contributor

I assume we will wait with this merge into master until we migrate to 3.6.0 then.

This comment has been minimized.

@berezovskyi
@berezovskyi

This comment has been minimized.

Copy link
Member

berezovskyi commented Jun 14, 2018

@neormx all the blocking patches have been merged. we are almost ready to merge yours – but now it has a merge conflict. could you please try to resolve it?

@berezovskyi
Copy link
Member

berezovskyi left a comment

please fix the merge issues first

@neormx

This comment has been minimized.

Copy link
Contributor Author

neormx commented Jun 14, 2018

Done.

neormx and others added some commits May 9, 2018

Bug 533213 - rdf:Seq deserialization in JMH contains no elements
Change-Id: Ieaa59912148e26ae943794f2201212f269b90474
Signed-off-by: Ricardo J Herrera <neormx@gmail.com>
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Update copyright headers
Change-Id: I8a73b5d14145e5544c8ffc955c90f9b5e0237dd5
Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
@berezovskyi

This comment has been minimized.

Copy link
Member

berezovskyi commented Jun 15, 2018

Ricardo, please review my last commit 39933c5 and then we are good to go.

@berezovskyi

This comment has been minimized.

Copy link
Member

berezovskyi commented Jun 15, 2018

@neormx

This comment has been minimized.

Copy link
Contributor Author

neormx commented Jun 15, 2018

It looks good to me @berezovskyi.

@berezovskyi berezovskyi merged commit d2c3e84 into eclipse:master Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment