New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra semicolon inserted in the SP Info class if the instance id was customised #36

Closed
berezovskyi opened this Issue Sep 3, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@berezovskyi
Copy link
Member

berezovskyi commented Sep 3, 2018

image

the corresponding instance ID is {twinKind}/{twinId}

@berezovskyi

This comment has been minimized.

Copy link
Member Author

berezovskyi commented Sep 3, 2018

does not cause compilation errors, low prio

jadelkhoury added a commit that referenced this issue Sep 6, 2018

closes #30: SP URI contructors are private
closes #36: Extra semicolon inserted in the SP Info class if the
instance id was customised

Providing a public method that can be used to create SP instances based
on SPInfo instances. This method can be dynically called to update the
set of provided SPs.

berezovskyi added a commit that referenced this issue Sep 8, 2018

SP URI contructors are private (#39); closes #30
SP URI contructors are private; closes #30

Providing a public method that can be used to create SP instances based
on SPInfo instances. This method can be dynically called to update the
set of provided SPs.

Introducing a containsKey method as well.

Also closes #36: Extra semicolon inserted in the SP Info class if the
instance id was customised

@berezovskyi berezovskyi added this to the 2.4.0 milestone Nov 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment