Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle oslc.where queries of strings that happen to contain an integer value. Also support for Integers. #54

Merged
merged 2 commits into from May 4, 2019

Conversation

Projects
None yet
2 participants
@jadelkhoury
Copy link
Contributor

commented May 4, 2019

Handle oslc.where queries of strings that happen to contain an integer value (example "123").
For some reason, the Jena QueryBuilder properly handle the creation of a where query where the string is "s-123", adding the expected "quotes" to the query. But for a string of value "123", the quotes are not added.

While at it, extend oslc.where queries to also support integers. Otherwise, I could not be sure that the solultion for the problem above is stable.

This problem is first reported under https://forum.open-services.net/t/lyo-store-oslc-query-with-sparql-issues-with-the-where-clause/224

@jadelkhoury jadelkhoury requested a review from berezovskyi May 4, 2019

@jadelkhoury jadelkhoury self-assigned this May 4, 2019

@berezovskyi

This comment has been minimized.

Copy link
Member

commented May 4, 2019

I am not sure if we shall keep non-SPARQL implementations much longer given the disparity.

Plus, I don't like the way to pass namespace definitions, but that's not for this PR to solve.

@jadelkhoury

This comment has been minimized.

Copy link
Contributor Author

commented May 4, 2019

I am not sure if we shall keep non-SPARQL implementations much longer given the disparity.

I'd be happy to remove the non-SPARQL implementations. Even the in-memory solutions? Not of interest to you?

Plus, I don't like the way to pass namespace definitions, but that's not for this PR to solve.

you mean oslc.prefix? I'm sticking to the way it is defined by OSLC. But sure, they are a pain to get the syntax right. We can easily construct that string internally.

@jadelkhoury jadelkhoury merged commit ee066ce into master May 4, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details

@berezovskyi berezovskyi deleted the stringOperandsWithIntegervalues branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.