Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify in Javadoc and spec that the default config includes discovered or default converters #348

Closed
OndroMih opened this issue Apr 19, 2018 · 0 comments

Comments

@OndroMih
Copy link
Contributor

commented Apr 19, 2018

As pointed out in https://groups.google.com/forum/#!topic/microprofile/3kXLoA1KVz8, I didn't find any hint in Javadoc or Spec text that injected Config and ConfigProvider.getConfig() should include discovered converters.

This is probably covered by the TCK but it makes it easier for implementers to clarify in the text.

@OndroMih OndroMih added this to the MP Config 1.3 milestone Apr 19, 2018

OndroMih added a commit that referenced this issue Apr 20, 2018
Clarification and test for using converters and injected config
Registered converters are applied in getValue() methods. Default config and injected config are equal (plus test). Default config registers discovered converters.
Fixes #348.
Signed-off-by:Ondrej Mihalyi <ondrej.mihalyi@payara.fish>

@Emily-Jiang Emily-Jiang changed the title Clarify in Javadoc and spec that the default config includes discovered converters Clarify in Javadoc and spec that the default config includes discovered or default converters Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.