Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the TCK to Arquilian #94

Closed
mmusgrov opened this issue Feb 6, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@mmusgrov
Copy link
Contributor

commented Feb 6, 2019

Refactoring of the TCK tests which provides Arquillian to base the integration on.
This adds Arquillian handling, changing few names and adding MicroProfile Config to the play.

When agreed on this approach and this is about to be merged I would like to continue with some more refactoring of the TCK codebase. There are still some comments and tests which needs to be clarified. This mostly migrates tests to be run with Arquillian but it does not do any changes in the logic of the tests.

The concept of the Arquillian integration is based on other spec (https://github.com/eclipse/microprofile-fault-tolerance/blob/master/tck/running_the_tck.asciidoc, https://github.com/eclipse/microprofile-health/blob/master/tck/running_the_tck.asciidoc).
The changes for Narayana LRA client are at: https://github.com/ochaloup/narayana/tree/lra-tck-arquillian-rework

As MicroProfile Config is used the timeout is configurable with changes provided here. The #60 are about to be covered by this PR.

@mmusgrov mmusgrov added this to the 1.0 milestone Feb 6, 2019

ochaloup added a commit to ochaloup/microprofile-lra that referenced this issue Feb 6, 2019

issue eclipse#94: TCK refactoring for Arquillian
Signed-off-by: Ondra Chaloupka <ochaloup@redhat.com>

Applying changes based on issue59

ochaloup added a commit to ochaloup/microprofile-lra that referenced this issue Feb 6, 2019

issue eclipse#94: TCK refactoring for Arquillian
Signed-off-by: Ondra Chaloupka <ochaloup@redhat.com>

Applying changes based on issue59

ochaloup added a commit to ochaloup/microprofile-lra that referenced this issue Feb 6, 2019

issue eclipse#94: TCK refactoring for Arquillian
Signed-off-by: Ondra Chaloupka <ochaloup@redhat.com>

Applying changes based on issue59

ochaloup added a commit to ochaloup/microprofile-lra that referenced this issue Feb 8, 2019

issue eclipse#94: TCK refactoring for Arquillian
Signed-off-by: Ondra Chaloupka <ochaloup@redhat.com>

Applying changes based on issue59

ochaloup added a commit to ochaloup/microprofile-lra that referenced this issue Feb 11, 2019

issue eclipse#94: TCK refactoring for Arquillian
Signed-off-by: Ondra Chaloupka <ochaloup@redhat.com>

Applying changes based on issue59

@mmusgrov mmusgrov closed this in #87 Feb 11, 2019

ochaloup added a commit to ochaloup/microprofile-lra that referenced this issue Feb 13, 2019

ochaloup added a commit to ochaloup/microprofile-lra that referenced this issue Feb 14, 2019

ochaloup added a commit to ochaloup/microprofile-lra that referenced this issue Feb 14, 2019

ochaloup added a commit to ochaloup/microprofile-lra that referenced this issue Feb 14, 2019

issue eclipse#94: fixes on arquillian refactoring
Signed-off-by: Ondra Chaloupka <ochaloup@redhat.com>

mmusgrov added a commit that referenced this issue Feb 14, 2019

Merge pull request #96 from ochaloup/tck-arquillian-refactoring-fixes
issue #94: fixes on arquillian refactoring

ochaloup added a commit to ochaloup/narayana that referenced this issue Feb 23, 2019

[JBTM-3109][lra#94] renaming LRA status complete/compensate to close/…
…cancel

Based on the changes in LRA TCK the LRA status methods were renamed to
close and cancel.

eclipse/microprofile-lra#94
eclipse/microprofile-lra#98

ochaloup added a commit to ochaloup/narayana that referenced this issue Mar 4, 2019

[JBTM-3109][lra#94] renaming LRA status complete/compensate to close/…
…cancel

Based on the changes in LRA TCK the LRA status methods were renamed to
close and cancel.

eclipse/microprofile-lra#94
eclipse/microprofile-lra#98

ochaloup added a commit to jbosstm/narayana that referenced this issue Mar 5, 2019

[JBTM-3109][lra#94] renaming LRA status complete/compensate to close/…
…cancel

Based on the changes in LRA TCK the LRA status methods were renamed to
close and cancel.

eclipse/microprofile-lra#94
eclipse/microprofile-lra#98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.