issue6 Timeout tests #267
issue6 Timeout tests #267
Conversation
| @@ -344,6 +346,31 @@ public void timeLimit() { | |||
| 1, lraMetricService.getMetric(LRAMetricType.Compensated, lraId, LraResource.class.getName())); | |||
| } | |||
|
|
|||
| /** | |||
| * Service A - Timeout 500 ms | |||
| * Service B - Type.MANDATORY`` | |||
There was a problem hiding this comment.
| * Service B - Type.MANDATORY`` | |
| * Service B - Type.MANDATORY |
tck/src/main/java/org/eclipse/microprofile/lra/tck/participant/api/LraResource.java
Outdated
Show resolved
Hide resolved
| return wae.getResponse(); | ||
| } catch (InterruptedException e) { | ||
| LOGGER.log(Level.FINE, "Interrupted because time limit elapsed", e); | ||
| fail("Interrupted because time limit elapsed"); |
There was a problem hiding this comment.
Will this work since this is a JAX-RS resource (i.e. not in the test)
There was a problem hiding this comment.
Good question, fail() (at least in junit4 master, today) seems to translate into an exception but I am not sure what a calling side receives if anything?
There was a problem hiding this comment.
500 I believe since with exception it's failed JAX-RS invocation.
There was a problem hiding this comment.
I will return a response code instead.
mmusgrov
force-pushed
the
issue6Timeouts
branch
from
486779b
to
f27d675
Compare
| // the next request should fail with a 412 code since the LRA should no longer be active | ||
| restPutInvocation(lraId, MANDATORY_LRA_RESOURCE_PATH, ""); | ||
| } catch (WebApplicationException wae) { | ||
| return wae.getResponse(); |
There was a problem hiding this comment.
| return wae.getResponse(); | |
| return Response.status(wae.getResponse().getStatus()).build(); |
I tested this locally and the response returned in wae from restPutInvocation is actually closed in this method [1] which fails the underlying JAX-RS implementation at least in Narayana.
There was a problem hiding this comment.
Thanks. I pushed your recommended fix.
mmusgrov
force-pushed
the
issue6Timeouts
branch
from
f27d675
to
db0ab3a
Compare
#6
The issue called for 3 different tests. I implemented the first one TckTests#timeLimitWithPreConditionFailed
The second test is very similar to TckTests#timeLimit so I have not added a one for that.
The third test that was asked for was to verify that the time limit is respected after a system crash. But we already have a test for that (see TckRecoveryTests#testCancelWhenParticipantIsUnavailable).