Add tracing for microprofile-rest-client #82
Comments
There has been some discussion in the past around spec integration and the need for a MP level spec to cover those interactions. Doing so would also provide for a MP level TCK to verify such behavior |
Is there any timeline to add MP level spec? My main concern about adding microprofile-rest-client here is that this spec shouldn't probably directly depend on the |
I don't think there is, but we can raise it again today |
@pavolloffay It should be possible to add Open Tracing providers to the MP Rest Client with only a compile-time dependency on |
Thorntail 2.3.0.Final documentation mentions this issue:
Is there any opened issue on Thorntail for MP-Restclient + MP-Opentracing? It still not working on Thorntail 2.3.0.Final. The test code is in this repo: https://github.com/redhat-developer-demos/microprofile-demo |
Hi @rafabene, the OT spec supports tracing for MP rest client 1.2. Here is a PR for smallrye smallrye/smallrye-opentracing#28 - at the moment is blocked by not completed rest client implementation. Once smallrye impls are in place it will be used in throntail @kenfinnigan probably knows when that should be. |
Hi @pavolloffay, I can see the PR is merged, does there is anything new about this request? |
@wutingbupt the support for MP rest client is supported since 1.2. What else is missing for you? |
@pavolloffay I have tried this morning with the open tracing 1.3. But I got something like this:
Br, |
@wutingbupt please report this issue in the implementation. This is not related to the specification. So please report this in Smallrye or thorntail depending how you are using it. A dependency tree would be helpful to investigate. |
Thanks very much, I will do that.
Br,
Tim
Pavol Loffay <notifications@github.com> 于2019年4月15日周一 下午1:06写道:
… @wutingbupt <https://github.com/wutingbupt> please report this issue in
the implementation. This is not related to the specification. So please
report this in Smallrye or thorntail depending how you are using it. A
dependency tree would be helpful to investigate.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#82 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABHXfdRQDCEw83t1q-oz3X4KoiHOQpokks5vhF0fgaJpZM4WF0Qa>
.
|
Add tracing for https://github.com/eclipse/microprofile-rest-client. Tracing metadata like tags/logs should be the same as for JAX-RS client.
We need to figure out how this cross-spec specification should be handled. Should it be added here or in microprofile-rest-client? I would vote to add it here.
cc @pilhuhn @kwsutter
A pointer to rest-client issue allowing tracing integration eclipse/microprofile-rest-client#35 (comment).
The text was updated successfully, but these errors were encountered: