New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing for microprofile-rest-client #82

Open
pavolloffay opened this Issue Aug 21, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@pavolloffay
Member

pavolloffay commented Aug 21, 2018

Add tracing for https://github.com/eclipse/microprofile-rest-client. Tracing metadata like tags/logs should be the same as for JAX-RS client.

We need to figure out how this cross-spec specification should be handled. Should it be added here or in microprofile-rest-client? I would vote to add it here.

cc @pilhuhn @kwsutter

A pointer to rest-client issue allowing tracing integration eclipse/microprofile-rest-client#35 (comment).

@kenfinnigan

This comment has been minimized.

Contributor

kenfinnigan commented Aug 21, 2018

There has been some discussion in the past around spec integration and the need for a MP level spec to cover those interactions.

Doing so would also provide for a MP level TCK to verify such behavior

@pavolloffay

This comment has been minimized.

Member

pavolloffay commented Aug 21, 2018

Is there any timeline to add MP level spec?

My main concern about adding microprofile-rest-client here is that this spec shouldn't probably directly depend on the microprofile-rest-client. What if a vendor does not support mp-rest-client but it wants to use tracing only for jax-rs?

@kenfinnigan

This comment has been minimized.

Contributor

kenfinnigan commented Aug 21, 2018

I don't think there is, but we can raise it again today

@andymc12

This comment has been minimized.

andymc12 commented Aug 21, 2018

@pavolloffay It should be possible to add Open Tracing providers to the MP Rest Client with only a compile-time dependency on microprofile-rest-client. You would need the compile-time dependency in order to build the RestClientBuilderListener implementation class (which could then register the Open Tracing provider(s)), but that class would only be loaded by the MP Rest Client implementation at runtime - so there is no need for a runtime dependency.

@pavolloffay pavolloffay added this to the 1.4 milestone Sep 12, 2018

@pavolloffay pavolloffay referenced a pull request that will close this issue Sep 14, 2018

Open

WIP: Instrument mp-rest-client #102

0 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment