From b4bb30354d216b45a13a80937bcac5c2995c8147 Mon Sep 17 00:00:00 2001
From: BJ Hargrave <bj@hargrave.dev>
Date: Wed, 18 May 2022 18:12:31 -0400
Subject: [PATCH] Configure javac to use --release when building on JDK 9+
 (#58)

We use the maven-compiler-plugin's `maven.compiler.release` property
to configure the --release value when building on JDK 9 or
later. Using --release is preferable to using --source/--target as
--release also factors in the class libraries available in the
release.

Unfortunately, setting this property when building on JDK 8 causes a
build error as the maven-compiler-plugin passes the --release option
to javac which does not understand it. So we use a maven profile to
set the property only when JDK is 9 or higher.

Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
---
 pom.xml | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index f1d4316..da1e102 100644
--- a/pom.xml
+++ b/pom.xml
@@ -32,8 +32,10 @@
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
 
         <!-- Compiler -->
-        <maven.compiler.source>1.8</maven.compiler.source>
-        <maven.compiler.target>1.8</maven.compiler.target>
+        <java.version>1.8</java.version>
+        <java.release>8</java.release>
+        <maven.compiler.source>${java.version}</maven.compiler.source>
+        <maven.compiler.target>${java.version}</maven.compiler.target>
 
         <!-- Dependencies - Jakarta -->
         <version.jakarta.annotation>2.0.0</version.jakarta.annotation>
@@ -50,6 +52,7 @@
         <!-- Plugins -->
         <version.microprofile.build-tools>1.1</version.microprofile.build-tools>
 
+        <version.plugin.compiler>3.10.1</version.plugin.compiler>
         <version.plugin.resources>3.2.0</version.plugin.resources>
         <version.plugin.jar>3.2.0</version.plugin.jar>
         <version.plugin.dependency>3.1.2</version.plugin.dependency>
@@ -210,6 +213,11 @@
     <build>
         <pluginManagement>
             <plugins>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-compiler-plugin</artifactId>
+                    <version>${version.plugin.compiler}</version>
+                </plugin>
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-resources-plugin</artifactId>
@@ -1099,5 +1107,15 @@
                 <tck.license>eftckl-1.0</tck.license>
             </properties>
         </profile>
+
+        <profile>
+            <id>java-release</id>
+            <activation>
+                <jdk>[9,)</jdk>
+            </activation>
+            <properties>
+                <maven.compiler.release>${java.release}</maven.compiler.release>
+            </properties>
+        </profile>
     </profiles>
 </project>