Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connector cross channel config properties #33

Merged

Conversation

hutchig
Copy link
Member

@hutchig hutchig commented May 20, 2019

Signed-off-by: Gordon Hutchison Gordon.Hutchison@gmail.com

As discussed in today's hangout.

Signed-off-by: Gordon Hutchison <Gordon.Hutchison@gmail.com>
@hutchig hutchig added this to the 1.0 milestone May 20, 2019
Copy link
Contributor

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a few comments. Before merging, I need to try implementing it, and the TCK needs to be extended to check this behavior.

spec/src/main/asciidoc/architecture.asciidoc Show resolved Hide resolved
spec/src/main/asciidoc/architecture.asciidoc Outdated Show resolved Hide resolved
spec/src/main/asciidoc/architecture.asciidoc Outdated Show resolved Hide resolved
Signed-off-by: Gordon Hutchison <Gordon.Hutchison@gmail.com>
@hutchig hutchig added the HOLD Don't merge currently label May 21, 2019
@hutchig
Copy link
Member Author

hutchig commented May 21, 2019

HOLD label as don't merge until merging on top of #22 as that affect the property name provider|connector etc.

@cescoffier
Copy link
Contributor

@hutchig I've made another PR on the TCK (not related to this change).

Signed-off-by: Gordon Hutchison <Gordon.Hutchison@gmail.com>
Signed-off-by: Gordon Hutchison <Gordon.Hutchison@gmail.com>
Signed-off-by: Gordon Hutchison <Gordon.Hutchison@gmail.com>
@hutchig
Copy link
Member Author

hutchig commented Jun 3, 2019

I cannot yet write/test tck changes as I have not built our connector support!

@hutchig hutchig requested a review from cescoffier June 3, 2019 21:44
@hutchig hutchig removed the HOLD Don't merge currently label Jun 3, 2019
@hutchig
Copy link
Member Author

hutchig commented Jun 3, 2019

Fixes 28 - well at least the concern that is left about having repeated similar properties for every channel of a connector.

@cescoffier
Copy link
Contributor

I will extend the TCK in another PR.
Wondering if we need to update the Factory classes with this content also (it mentions the configuration format). WDYT?

@cescoffier cescoffier merged commit 52d6fad into eclipse:master Jun 4, 2019
@cescoffier
Copy link
Contributor

Merging, the rest of the work can be done in other PRs.

@hutchig
Copy link
Member Author

hutchig commented Jun 4, 2019

Thanks for merging - feel free to do this (from my POV) for any of my PRs that I request a review for that I have not put a HOLD label on.

@hutchig
Copy link
Member Author

hutchig commented Jun 4, 2019

I did the javadoc changes for the Factories under #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants