New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connector cross channel config properties #33
Add connector cross channel config properties #33
Conversation
Signed-off-by: Gordon Hutchison <Gordon.Hutchison@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a few comments. Before merging, I need to try implementing it, and the TCK needs to be extended to check this behavior.
Signed-off-by: Gordon Hutchison <Gordon.Hutchison@gmail.com>
HOLD label as don't merge until merging on top of #22 as that affect the property name provider|connector etc. |
@hutchig I've made another PR on the TCK (not related to this change). |
Signed-off-by: Gordon Hutchison <Gordon.Hutchison@gmail.com>
Signed-off-by: Gordon Hutchison <Gordon.Hutchison@gmail.com>
Signed-off-by: Gordon Hutchison <Gordon.Hutchison@gmail.com>
I cannot yet write/test tck changes as I have not built our connector support! |
Fixes 28 - well at least the concern that is left about having repeated similar properties for every channel of a connector. |
I will extend the TCK in another PR. |
Merging, the rest of the work can be done in other PRs. |
Thanks for merging - feel free to do this (from my POV) for any of my PRs that I request a review for that I have not put a HOLD label on. |
I did the javadoc changes for the Factories under #42 |
Signed-off-by: Gordon Hutchison Gordon.Hutchison@gmail.com
As discussed in today's hangout.