Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming artifactId, groupId, Packages and various fixes #116

Merged
merged 14 commits into from Dec 12, 2018
Merged

Conversation

@cescoffier
Copy link
Contributor

cescoffier commented Dec 11, 2018

As discussed Today at the Microprofile Reactive hangout:

  • change groupId
  • Change artifactId
  • Update projects name and description
  • Rename packages
  • Merge the Arquillian TCK in the standalone TCK, and delete the arquillian TCK module
  • Update Arquillian TCK Javadoc

In addition,

  • Fix OSGi metadata for the API module
  • Add OSGi metadata for the Core module
  • Various fixes in the spec to reflect the changes
cescoffier added 14 commits Dec 11, 2018
As discussed during the MicroProfile Reactive Hangout (Dec 11th, 2018)

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
It is going to be merged in the TCK module

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
…tors`

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
…s.core

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
They are going to be merged in the main TCK artifact.

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Javadoc has been updated to contain explanations about the usage.

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
…ators

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
* Arquillian TCK has been merged with the standalone TCK
* Update class names (due to package renaming)

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
(violation of the checkstyle rules)

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
@cescoffier cescoffier self-assigned this Dec 11, 2018
@cescoffier cescoffier requested a review from jroper Dec 11, 2018
@jroper jroper merged commit 328f261 into master Dec 12, 2018
1 check passed
1 check passed
default Build finished.
Details
@jroper jroper deleted the renaming-artifacts branch Dec 12, 2018
@jroper

This comment has been minimized.

Copy link
Member

jroper commented Dec 12, 2018

I have to go now, but while testing this I found a bug in the coupled TCK verification - it's calling run() rather than run(getEngine()).

@cescoffier

This comment has been minimized.

Copy link
Contributor Author

cescoffier commented Dec 12, 2018

@jroper Let me fix that issue!

cescoffier added a commit that referenced this pull request Dec 12, 2018
Issue found by James in #116.
The fix is trivial.

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.