Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic-Module-Name needs to be unique for each maven module #584

Closed
comtel2000 opened this issue Jan 6, 2020 · 3 comments
Closed

Automatic-Module-Name needs to be unique for each maven module #584

comtel2000 opened this issue Jan 6, 2020 · 3 comments

Comments

@comtel2000
Copy link
Contributor

@comtel2000 comtel2000 commented Jan 6, 2020

based on #442 please choose a dedicated automatic module name for each maven module (stack-client, stack-core, sdk-client, etc.).

current 'stack-core' MANIFEST.MF:

..
Automatic-Module-Name: org.eclipse.milo.opcua
Bundle-License: https://www.eclipse.org/org/documents/epl-2.0/EPL-2.0.
 html
Bundle-SymbolicName: org.eclipse.milo.stack-core
Implementation-Version: 0.3.6
..

needs to be changed into:

..
Automatic-Module-Name: org.eclipse.milo.stack.core
..

Just like the Bundle-SymbolicName just with '.' instead of '-'

@comtel2000

This comment has been minimized.

Copy link
Contributor Author

@comtel2000 comtel2000 commented Jan 6, 2020

or changed to the root package name (stack-core):

..
Automatic-Module-Name: org.eclipse.milo.opcua.stack.core
..
@kevinherron

This comment has been minimized.

Copy link
Contributor

@kevinherron kevinherron commented Jan 6, 2020

I think I'll just use the root package name. Should be able to do this and release it with 0.3.7 this week.

@comtel2000

This comment has been minimized.

Copy link
Contributor Author

@comtel2000 comtel2000 commented Jan 6, 2020

Thanks, that's really quick :)

comtel2000 added a commit to comtel2000/milo that referenced this issue Jan 7, 2020
Signed-off-by: Joerg Zimmermann <comtel2000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.