Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake build invokes ldconfig #1048

Closed
gdt opened this issue Nov 20, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@gdt
Copy link

commented Nov 20, 2018

The cmake build invokes ldconfig. This is more or less a Linux thing, so it's odd that a build for Mac and Windows invokes it, but that's not important.

Invoking ldconfig is nonportable, and it's also tricky on Linux. Most packages don't call ldconfig, and a normal expectation would be for that to happen outside of package building or package installation.

If ldconfig is going to be run, it needs to be guarded so that all of the following are true:

  • ldconfig is only run on Linux, or some set of systems known to want ldconfig
  • ldconfig is only run if running as root
  • ldconfig is only run if DESTDIR is not set

Overall, I would suggest entirely removing it.

@ralight ralight modified the milestones: 1.5.8, 1.6.1 Apr 26, 2019

@ralight ralight closed this Apr 26, 2019

ralight added a commit that referenced this issue Apr 26, 2019

Don't call ldconfig in CMake scripts.
Closes #1048. Thanks to Greg Troxel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.