New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bridge remote_username with spaces doesn't work #1131

Closed
beville opened this Issue Jan 29, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@beville
Copy link

beville commented Jan 29, 2019

I'm trying to set the bridge username to be something with spaces. For example:

remote_username user one

Unfortunately the config parser doesn't seem to like this. I see there is an older issue (#150) that had the same issue for the bridge password.

For someone who knows this config parser well, this would probably be a pretty straightforward fix.

@beville

This comment has been minimized.

Copy link
Author

beville commented Jan 29, 2019

I actually had a go at this, and I got it to work. Not fully tested, though, so instead of a pull request, just attaching a patch file (zipped).

remote_username_spaces.patch.zip

@ralight

This comment has been minimized.

Copy link
Contributor

ralight commented Feb 3, 2019

That's lovely, thanks very much. I've made the appropriate change on my local branch and it will be part of 1.5.6 soon.

@ralight ralight closed this Feb 3, 2019

@ralight ralight added this to the 1.5.6 milestone Feb 3, 2019

@karlp

This comment has been minimized.

Copy link
Contributor

karlp commented Feb 4, 2019

(incoming, bug reports that usernames can't start or end with quote marks...., spec says it can be any utf8 encoded string)

ralight added a commit that referenced this issue Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment