Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test build does not respect CPPFLAGS/LDFLAGS from environment #1232

Closed
gdt opened this issue Apr 18, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@gdt
Copy link

commented Apr 18, 2019

Doing "gmake tests" (without cmake) does not respect CPPFLAGS and LDFLAGS from the environment. This is needed in my case to find CUnit and uthash, which are built with prefix of /usr/pkg. This is an issue in the tests subdirectory, not just top-level.

The test makefile does not separate LDFLAGS (for -L/-R) and LDADD (for -lfoo). That contributes to not being able to pass in LDFLAGS.

(I believe that the non-cmake build should be retired, but as it is the only way to run tests at the moment, I thought I should report this.)

@ralight

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

This is fixed for 1.6.1, thanks.

@ralight ralight closed this Apr 26, 2019

@ralight ralight added this to the 1.6.1 milestone Apr 26, 2019

ralight added a commit that referenced this issue Apr 26, 2019

Build fixes around CFLAGS et al.
- Split CFLAGS and CPPFLAGS, and LDFLAGS and LDADD/LIBADD.
- test/unit now respects CPPFLAGS and LDFLAGS.

Closes #1232. Thanks to Greg Troxel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.