Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mosquitto crash when using will with properties V5 #1244

Closed
ckrey opened this issue Apr 29, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@ckrey
Copy link

commented Apr 29, 2019

Problem occurs with any -D will ... property. When will is sent, mosquitto crashes

$ mosquitto_sub -V 5 -t '#' -v --will-topic will-topic --will-payload will-payload -D will payload-format-indicator 0

^C

mosquitto log to stderr:

2019-04-29T14:48:00: mosquitto version 1.6.1 starting
2019-04-29T14:48:00: Config loaded from mosquitto.conf.
2019-04-29T14:48:00: Opening ipv4 listen socket on port 1883.
2019-04-29T14:48:06: New connection from 127.0.0.1 on port 1883.
2019-04-29T14:48:06: New client connected from 127.0.0.1 as auto-05311622-D23C-E6C7-6285-4D54A804AC50 (p5, c1, k60).
2019-04-29T14:48:06: Will message specified (12 bytes) (r0, q0).
2019-04-29T14:48:06: 	will-topic
2019-04-29T14:48:06: Sending CONNACK to auto-05311622-D23C-E6C7-6285-4D54A804AC50 (0, 0)
2019-04-29T14:48:06: Received SUBSCRIBE from auto-05311622-D23C-E6C7-6285-4D54A804AC50
2019-04-29T14:48:06: 	# (QoS 0)
2019-04-29T14:48:06: auto-05311622-D23C-E6C7-6285-4D54A804AC50 0 #
2019-04-29T14:48:06: Sending SUBACK to auto-05311622-D23C-E6C7-6285-4D54A804AC50
2019-04-29T14:48:10: Socket error on client auto-05311622-D23C-E6C7-6285-4D54A804AC50, disconnecting.
free(): double free detected in tcache 2
Aborted

@ralight ralight added this to the 1.6.2 milestone Apr 29, 2019

@ralight

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

Thanks Christoph, it's not quite as simple as "all" of them, but is still bad. I'll get a fix out in the morning.

@ralight ralight closed this Apr 29, 2019

@ckrey

This comment has been minimized.

Copy link
Author

commented Apr 30, 2019

Thanks for the quick response.
I have to admit, I didn't try all possible properties, but two or three of them

ralight added a commit that referenced this issue Apr 30, 2019

Fix access after free when v5 client with Will message disconnects.
The Will message has as its first property one of content-type,
correlation-data, payload-format-indicator, or response-topic.

Closes #1244. Thanks to Christoph Krey.

ccvca added a commit to ccvca/mosquitto that referenced this issue May 1, 2019

Fix access after free when v5 client with Will message disconnects.
The Will message has as its first property one of content-type,
correlation-data, payload-format-indicator, or response-topic.

Closes eclipse#1244. Thanks to Christoph Krey.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.