Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure when WITH_TLS=OFF, Linux #1250

Closed
bmparr opened this issue Apr 29, 2019 · 6 comments

Comments

Projects
None yet
3 participants
@bmparr
Copy link

commented Apr 29, 2019

Minor build issue on GNU/Linux:
mkdir build
cd build
cmake -DWITH_TLS:BOOL=OFF ..
make

mosquitto-1.6.1/src/net.c: In function ‘net__socket_listen’:
mosquitto-1.6.1/src/net.c:442:2: error: ‘rc’ undeclared (first use in this function)

ln 421: 'int rc;' is hidden in #ifdef/#endif

ralight added a commit that referenced this issue Apr 29, 2019

Fix build for WITH_TLS=no.
Closes #1250. Thanks to bmparr.
@ralight

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

Thank you!

Is this option important to you? I've been considering removing the option to compile without TLS support.

@bmparr

This comment has been minimized.

Copy link
Author

commented Apr 30, 2019

@ralight

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

Thanks for the explanation Bruce. Yes, there isn't support for OpenSSL 1.0.1 because it is not supported by OpenSSL itself. It's fairly straightforward to remove the ALPN code, it doesn't touch much, but I wouldn't want to guarantee there isn't something else that is going to cause problems for you on 1.0.1. There's not a big rush to remove the option of WITH_TLS=no, so I can put that back for a while, probably to 2.0.

@ralight ralight closed this Apr 30, 2019

@ralight ralight added this to the 1.6.2 milestone Apr 30, 2019

@karlp

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

hijacking a little, but there's quite a few peole on openwrt using the -nossl package variant, as the openssl lib is too big for them, and they're using them in closed internal systems. You can search for "mosquitto" on https://downloads.openwrt.org/stats/awstats.downloads2.lede-project.org.allextra2.html (but that's not a long term list just people that download post install, rather than build their own)

@ralight

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

@karlp That's good to know, thanks.

@karlp

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

Heading off into the woods, but mbed-tls has become the "goto" "small" tls option. If there was an mbed-tls option, I could convince people that mosquitto is TLS ONLY but openssl is a hard sell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.