Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client binaries do not respect LDFLAGS #1294

Closed
oxr463 opened this issue May 27, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@oxr463
Copy link

commented May 27, 2019

Compiled with the command, LDFLAGS="-Wl,--defsym=__check_ldflags__=0" CLIENT_LDFLAGS="${LDFLAGS}" make.

Output from objdump:

objdump -x lib/libmosquitto.so.1 | grep __check
0000000000011340 l     F .text  000000000000016e              mosquitto__check_keepalive
000000000000ceb0 l     F .text  000000000000003b              packet__check_oversize
0000000000000000 l       *ABS*  0000000000000000              __check_ldflags__
objdump -x client/mosquitto_pub | grep __check
objdump -x client/mosquitto_sub | grep __check
objdump -x client/mosquitto_rr | grep __check

Note: checking for the __check_ldflags__ symbol returned 1 for the client binaries.

@oxr463

This comment has been minimized.

Copy link
Author

commented May 27, 2019

If I pass the -e flag to make it will respect the environment variables.

See also: #1232

@oxr463 oxr463 closed this May 27, 2019

ralight added a commit that referenced this issue May 29, 2019

CLIENT_LDFLAGS now uses LDFLAGS.
Closes #1294. Thanks to Lucas Ramage.
@ralight

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

You can now do this with just make LDFLAGS="-Wl,--defsym=__check_ldflags__=0" in the fixes branch.

ralight added a commit that referenced this issue Jun 6, 2019

CLIENT_LDFLAGS now uses LDFLAGS.
Closes #1294. Thanks to Lucas Ramage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.